Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SearchServiceClient needs to send odata.metadata in Accept request header #11532

Closed
heaths opened this issue Apr 23, 2020 · 0 comments · Fixed by #11562
Closed

SearchServiceClient needs to send odata.metadata in Accept request header #11532

heaths opened this issue Apr 23, 2020 · 0 comments · Fixed by #11562
Assignees
@heaths
Labels
Client This issue points to a problem in the data-plane of the library. Search
Milestone
[2020] May

Comments

@heaths
Copy link
Member

heaths commented Apr 23, 2020

Based on #11420 (comment), we should be setting the Accept header for SearchServiceClient to "application/json;odata.metadata=minimal". I also see in track 1 that document operations for SearchIndexClient set Accept to "application/json;odata.metadata=none". Track 2 code is currently doing neither, but the service seems to default to returning odata.metadata=minimal, based on recorded test documents.

/cc @brjohnstmsft @tg-msft
@heaths heaths added Search Client This issue points to a problem in the data-plane of the library. labels Apr 23, 2020
@heaths heaths added this to the [2020] May milestone Apr 23, 2020
@heaths heaths self-assigned this Apr 24, 2020
heaths added a commit to heaths/azure-sdk-for-net that referenced this issue Apr 24, 2020
@heaths
Set appropriate Accept header for Search clients
913b7ab 
Fixes Azure#11532
@heaths heaths mentioned this issue Apr 24, 2020
Merged
heaths added a commit that referenced this issue Apr 28, 2020
@heaths
Set appropriate Accept header for Search clients (#11562)
7faf72e 
* Set appropriate Accept header for Search clients

Fixes #11532

* Resolve PR feedback

* Unconditionally change the Content-Length in sanitizer
@github-actions github-actions bot locked and limited conversation to collaborators Mar 28, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@heaths heaths

Labels
Client This issue points to a problem in the data-plane of the library. Search
Projects
None yet
Milestone
[2020] May
Development

Successfully merging a pull request may close this issue.

Set appropriate Accept header for Search clients heaths/azure-sdk-for-net
1 participant
@heaths