-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add NativeBlobSoftDeleteDeletionDetectionPolicy to Microsoft.Azure.Search library #11435
Comments
/cc @heaths as this would be on our data source APIs |
Thanks for bringing this to my attention. The new packages do support it, but perhaps not in a very intuitive way. @brjohnstmsft, right now these are exposed as models that just need to exist in the JSON payload. I suggest we make them boolean properties like |
Sorry, I see those classes should actually be |
@heaths I defer to @bleroy or @arv100kri for API design opinions in this area. |
Blocked on Azure/azure-rest-api-specs#9160. This could be done without but requires taking over de/serialization completely instead of using generated code, which continues to evolve. At least, we can wait until time no longer allows for getting a change to swagger. |
@bleroy, @arv100kri do you have any timeframe for defining this type in swagger?
|
Thanks for the feedback! We are routing this to the appropriate team for follow-up. cc @felixwa, @brjohnstmsft. |
Blocked on the service team, so punting to preview 5 since this is only additive. |
It doesn't look like this is going to make it, so punting. |
@heaths In cases like this where SDK changes are blocked on Swagger changes, I recommend putting the "Service Attention" tag only on the Swagger issue in azure-rest-api-specs. Otherwise, ownership isn't clear and our issue SLA metrics are affected. I've removed the tag since it's already present on the corresponding azure-rest-api-specs issue. |
This is tracking Azure/azure-rest-api-specs#9160 which is both in that repo and has the "Service Attention" tag. This is to complete our work once done. |
This has been merged into Track 2 SDK. PR: Azure/azure-rest-api-specs#10308 @heaths can this issue be closed? |
Yes. Thanks for the reminder. Support for this will be in the Azure.Search.Documents package. |
@heaths , did this get included in Azure.Search.Documents? I see no use of the phrase NativeBlobSoftDeleteDeletionDetectionPolicy anywhere in https://github.com/Azure/azure-sdk-for-net. Shouldn't it be here with SoftDeleteColumnDeletionDetectionPolicy: |
@jennifermarsman, @jadrefke - the update to the REST spec was reverted a few weeks after it was added and it has been like that since. Are there plans to add it back? |
We don't have immediate plans to expose this functionality via the SDK. Will update this issue once we add it. cc: @gmndrg, @dereklegenzoff |
Is there a separate issue I should monitor to keep an eye on this since this issue was closed? |
Is the Azure.Search.Document still being updated? The last beta version released was in November 2021. |
Hello @a2741890, yes, please check https://www.nuget.org/packages/Azure.Search.Documents/#versions-body-tab You can see the latest beta versions and the latest was out 4 days ago. The original thread is already closed. For new threads, please submit a new issue. Thank you. |
Library or service name.
Microsoft.Auzre.Search
Is your feature request related to a problem? Please describe.
It appears that since the 09/2019 release you have had a public preview of "NativeBlobSoftDeleteDeletionDetectionPolicy" delete policy.
However the Microsoft.Azure.Search does not have an ability to define that deletion policy.
Information about Native blob soft delete is here: https://docs.microsoft.com/en-us/azure/search/search-howto-indexing-azure-blob-storage
The text was updated successfully, but these errors were encountered: