Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Azure.Search: Fix ClientRequestId tests when supported by the generator #10604

Closed
tg-msft opened this issue Mar 13, 2020 · 1 comment · Fixed by #11942
Closed

Azure.Search: Fix ClientRequestId tests when supported by the generator #10604

tg-msft opened this issue Mar 13, 2020 · 1 comment · Fixed by #11942
Assignees
@tg-msft
Labels
Client This issue points to a problem in the data-plane of the library. Search
Milestone
[2020] June

Comments

@tg-msft
Copy link
Member

tg-msft commented Mar 13, 2020

The generator currently sets the header and it gets stomped by the policy. We're going to have a broader discussion about ClientRequestId support.
@tg-msft tg-msft added Client This issue points to a problem in the data-plane of the library. Search labels Mar 13, 2020
@tg-msft tg-msft self-assigned this Mar 13, 2020
@tg-msft tg-msft added this to the [2020] May milestone Mar 19, 2020
@AlexGhiondea AlexGhiondea mentioned this issue Apr 8, 2020
Closed
26 tasks
@tg-msft
Copy link
Member Author

tg-msft commented Apr 13, 2020

Will finish after #11198.

heaths added a commit to heaths/azure-sdk-for-net that referenced this issue May 8, 2020
@heaths
Create new indexes instead of Search services
523a588 
This prevents us from spamming Search with too many requests for free services, instead opting to create one free service per test platform, and creating and destroying indexes instead.

Also fixes Azure#10604. The upstream bug was resolved a while ago, but the PlaybackTransport wasn't copying the ClientRequestId like the HttpTransport and RecordTransport do.
@heaths heaths mentioned this issue May 8, 2020
Merged
heaths added a commit to heaths/azure-sdk-for-net that referenced this issue May 8, 2020
@heaths
Create new indexes instead of Search services
f9c4993 
This prevents us from spamming Search with too many requests for free services, instead opting to create one free service per test platform, and creating and destroying indexes instead.

Also fixes Azure#10604. The upstream bug was resolved a while ago, but the PlaybackTransport wasn't copying the ClientRequestId like the HttpTransport and RecordTransport do.
@tg-msft tg-msft modified the milestones: [2020] May, [2020] June May 8, 2020
@AlexGhiondea AlexGhiondea mentioned this issue May 8, 2020
Closed
17 tasks
heaths added a commit that referenced this issue May 9, 2020
@heaths
Create new indexes instead of Search services (#11942)
65165f5 
* Create new indexes instead of Search services

This prevents us from spamming Search with too many requests for free services, instead opting to create one free service per test platform, and creating and destroying indexes instead.

Also fixes #10604. The upstream bug was resolved a while ago, but the PlaybackTransport wasn't copying the ClientRequestId like the HttpTransport and RecordTransport do.

* Fix test to not fail in rare cases

Still investigating why one test occasionally finds 20 docs instead of
10 even though it doesn't use a shared resources. For now, anything >=
   10 still proves the test worked so we don't fail the whole run.
@github-actions github-actions bot locked and limited conversation to collaborators Mar 28, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@tg-msft tg-msft

Labels
Client This issue points to a problem in the data-plane of the library. Search
Projects
None yet
Milestone
[2020] June
Development

Successfully merging a pull request may close this issue.

Create new indexes instead of Search services heaths/azure-sdk-for-net
1 participant
@tg-msft