[synapse] Reenable AccessControlClientLiveTests as LiveOnly. Mark oth…

…ers as RecordedTest (#18499) - Give up on making AccessControlClientLiveTests record-able and mark as LiveOnly - [RecordedTest] seems to be a flatly better [Test] for all RecordedTestBase derived tests, so use it
Azure · Feb 9, 2021 · eb0ba42 · eb0ba42
1 parent e3a7aab
commit eb0ba42
Show file tree

Hide file tree

Showing 31 changed files with 64 additions and 2,059 deletions.
diff --git a/sdk/synapse/Azure.Analytics.Synapse.AccessControl/tests/AccessControlClientLiveTests.cs b/sdk/synapse/Azure.Analytics.Synapse.AccessControl/tests/AccessControlClientLiveTests.cs
@@ -20,7 +20,7 @@ namespace Azure.Analytics.Synapse.AccessControl.Tests
     /// These tests have a dependency on live Azure services and may incur costs for the associated
     /// Azure subscription.
     /// </remarks>
-    [Ignore("https://github.com/Azure/azure-sdk-for-net/issues/18080 - roleAssignmentId can not be reused in recording due to reuse 409.")]
+    [LiveOnly] // Assignment IDs can not be reused for at least 30 days.
     public class AccessControlClientLiveTests : RecordedTestBase<SynapseTestEnvironment>
     {
         internal class DisposableClientRole : IAsyncDisposable
@@ -34,27 +34,16 @@ private DisposableClientRole (RoleAssignmentsClient assignmentsClient, RoleDefin
                 Assignment = assignment;
             }
 
-            public static async ValueTask<DisposableClientRole> Create (RoleAssignmentsClient assignmentsClient, RoleDefinitionsClient definitionsClient, TestRecording recording) =>
-                new DisposableClientRole (assignmentsClient, definitionsClient, await CreateResource (assignmentsClient, definitionsClient, recording));
+            public static async ValueTask<DisposableClientRole> Create (RoleAssignmentsClient assignmentsClient, RoleDefinitionsClient definitionsClient) =>
+                new DisposableClientRole (assignmentsClient, definitionsClient, await CreateResource (assignmentsClient, definitionsClient));
 
-            public static async ValueTask<RoleAssignmentDetails> CreateResource (RoleAssignmentsClient assignmentsClient, RoleDefinitionsClient definitionsClient, TestRecording recording)
+            public static async ValueTask<RoleAssignmentDetails> CreateResource (RoleAssignmentsClient assignmentsClient, RoleDefinitionsClient definitionsClient)
             {
                 string scope = "workspaces/workspacechhamosynapse";
 
                 Guid? roleID = (await definitionsClient.ListRoleDefinitionsAsync()).Value.First (x => x.Name == "Synapse Administrator").Id;
-                Guid principalId = recording.Random.NewGuid();
-
-                string roleAssignmentId;
-                // Assignment IDs can not be reused for at least 30 days, so only respect recording's copy in playback
-                if (recording.Mode == RecordedTestMode.Playback)
-                {
-                    roleAssignmentId = recording.Random.NewGuid().ToString();
-                }
-                else
-                {
-                    roleAssignmentId = Guid.NewGuid().ToString();
-                }
-
+                Guid principalId = Guid.NewGuid();
+                string roleAssignmentId = Guid.NewGuid().ToString();
                 return await assignmentsClient.CreateRoleAssignmentAsync(roleAssignmentId, roleID.Value, principalId, scope);
             }
 
@@ -92,7 +81,7 @@ public async Task CreateRoleAssignment()
             RoleAssignmentsClient assignmentsClient = CreateAssignmentClient();
             RoleDefinitionsClient definitionsClient = CreateDefinitionsClient();
 
-            await using DisposableClientRole role = await DisposableClientRole.Create (assignmentsClient, definitionsClient, this.Recording);
+            await using DisposableClientRole role = await DisposableClientRole.Create (assignmentsClient, definitionsClient);
 
             Assert.NotNull(role.Assignment.Id);
             Assert.NotNull(role.Assignment.RoleDefinitionId);
@@ -105,7 +94,7 @@ public async Task GetRoleAssignment()
             RoleAssignmentsClient assignmentsClient = CreateAssignmentClient();
             RoleDefinitionsClient definitionsClient = CreateDefinitionsClient();
 
-            await using DisposableClientRole role = await DisposableClientRole.Create (assignmentsClient, definitionsClient, this.Recording);
+            await using DisposableClientRole role = await DisposableClientRole.Create (assignmentsClient, definitionsClient);
 
             RoleAssignmentDetails roleAssignment = await assignmentsClient.GetRoleAssignmentByIdAsync(role.Assignment.Id);
 
@@ -119,7 +108,7 @@ public async Task ListRoleAssignments()
             RoleAssignmentsClient assignmentsClient = CreateAssignmentClient();
             RoleDefinitionsClient definitionsClient = CreateDefinitionsClient();
 
-            await using DisposableClientRole role = await DisposableClientRole.Create (assignmentsClient, definitionsClient, this.Recording);
+            await using DisposableClientRole role = await DisposableClientRole.Create (assignmentsClient, definitionsClient);
 
             Response<IReadOnlyList<SynapseRoleDefinition>> roleAssignments = await definitionsClient.ListRoleDefinitionsAsync();
             foreach (SynapseRoleDefinition expected in roleAssignments.Value)
@@ -137,7 +126,7 @@ public async Task DeleteRoleAssignments()
             RoleAssignmentsClient assignmentsClient = CreateAssignmentClient();
             RoleDefinitionsClient definitionsClient = CreateDefinitionsClient();
 
-            RoleAssignmentDetails assignment = await DisposableClientRole.CreateResource (assignmentsClient, definitionsClient, this.Recording);
+            RoleAssignmentDetails assignment = await DisposableClientRole.CreateResource (assignmentsClient, definitionsClient);
 
             Response response = await assignmentsClient.DeleteRoleAssignmentByIdAsync (assignment.Id);
             response.AssertSuccess();

diff --git a/...AccessControl/tests/SessionRecords/AccessControlClientLiveTests/CreateRoleAssignment.json b/...AccessControl/tests/SessionRecords/AccessControlClientLiveTests/CreateRoleAssignment.json
diff --git a/...sControl/tests/SessionRecords/AccessControlClientLiveTests/CreateRoleAssignmentAsync.json b/...sControl/tests/SessionRecords/AccessControlClientLiveTests/CreateRoleAssignmentAsync.json
diff --git a/...ccessControl/tests/SessionRecords/AccessControlClientLiveTests/DeleteRoleAssignments.json b/...ccessControl/tests/SessionRecords/AccessControlClientLiveTests/DeleteRoleAssignments.json
diff --git a/...Control/tests/SessionRecords/AccessControlClientLiveTests/DeleteRoleAssignmentsAsync.json b/...Control/tests/SessionRecords/AccessControlClientLiveTests/DeleteRoleAssignmentsAsync.json
diff --git a/...essControl/tests/SessionRecords/AccessControlClientLiveTests/GetCallerRoleAssignment.json b/...essControl/tests/SessionRecords/AccessControlClientLiveTests/GetCallerRoleAssignment.json
diff --git a/...ntrol/tests/SessionRecords/AccessControlClientLiveTests/GetCallerRoleAssignmentAsync.json b/...ntrol/tests/SessionRecords/AccessControlClientLiveTests/GetCallerRoleAssignmentAsync.json
diff --git a/...se.AccessControl/tests/SessionRecords/AccessControlClientLiveTests/GetRoleAssignment.json b/...se.AccessControl/tests/SessionRecords/AccessControlClientLiveTests/GetRoleAssignment.json
diff --git a/...cessControl/tests/SessionRecords/AccessControlClientLiveTests/GetRoleAssignmentAsync.json b/...cessControl/tests/SessionRecords/AccessControlClientLiveTests/GetRoleAssignmentAsync.json
diff --git a/....AccessControl/tests/SessionRecords/AccessControlClientLiveTests/ListRoleAssignments.json b/....AccessControl/tests/SessionRecords/AccessControlClientLiveTests/ListRoleAssignments.json
diff --git a/...ssControl/tests/SessionRecords/AccessControlClientLiveTests/ListRoleAssignmentsAsync.json b/...ssControl/tests/SessionRecords/AccessControlClientLiveTests/ListRoleAssignmentsAsync.json
diff --git a/sdk/synapse/Azure.Analytics.Synapse.Artifacts/tests/BigDataPoolsClientLiveTests.cs b/sdk/synapse/Azure.Analytics.Synapse.Artifacts/tests/BigDataPoolsClientLiveTests.cs
@@ -35,7 +35,7 @@ private BigDataPoolsClient CreateClient()
         }
 
         [Ignore("https://github.com/Azure/azure-sdk-for-net/issues/18080 - This test case cannot be automated due to the inability to configure infrastructure to test against.")]
-        [Test]
+        [RecordedTest]
         public async Task ListPools()
         {
             BigDataPoolsClient client = CreateClient();
@@ -44,7 +44,7 @@ public async Task ListPools()
         }
 
         [Ignore("https://github.com/Azure/azure-sdk-for-net/issues/18080 - This test case cannot be automated due to the inability to configure infrastructure to test against.")]
-        [Test]
+        [RecordedTest]
         public async Task GetPool()
         {
             const string PoolName = "sparkchhamosyna";

diff --git a/sdk/synapse/Azure.Analytics.Synapse.Artifacts/tests/DataFlowClientLiveTests.cs b/sdk/synapse/Azure.Analytics.Synapse.Artifacts/tests/DataFlowClientLiveTests.cs
@@ -33,7 +33,7 @@ private DataFlowClient CreateClient()
             ));
         }
 
-        [Test]
+        [RecordedTest]
         public async Task GetDataFlows()
         {
             DataFlowClient client = CreateClient();
@@ -43,7 +43,7 @@ public async Task GetDataFlows()
             Assert.GreaterOrEqual((await dataFlows.ToListAsync()).Count, 1);
         }
 
-        [Test]
+        [RecordedTest]
         public async Task GetDataFlow()
         {
             DataFlowClient client = CreateClient();
@@ -53,7 +53,7 @@ public async Task GetDataFlow()
             Assert.AreEqual (flow.Name, dataFlow.Name);
         }
 
-        [Test]
+        [RecordedTest]
         public async Task RenameDataFlow()
         {
             DataFlowClient client = CreateClient();
@@ -72,7 +72,7 @@ public async Task RenameDataFlow()
             await operation.WaitForCompletionAsync();
         }
 
-        [Test]
+        [RecordedTest]
         public async Task DeleteDataFlow()
         {
             DataFlowClient client = CreateClient();

diff --git a/sdk/synapse/Azure.Analytics.Synapse.Artifacts/tests/DataFlowDebugSessionClientLiveTests.cs b/sdk/synapse/Azure.Analytics.Synapse.Artifacts/tests/DataFlowDebugSessionClientLiveTests.cs
@@ -75,7 +75,7 @@ private DataFlowDebugSessionClient CreateDebugClient()
         }
 
         [Ignore ("https://github.com/Azure/azure-sdk-for-net/issues/18079 prevents test from working")]
-        [Test]
+        [RecordedTest]
         public async Task AddDataFlow()
         {
             DataFlowClient flowClient = CreateFlowClient();
@@ -90,7 +90,7 @@ public async Task AddDataFlow()
             Assert.NotNull (response.JobVersion);
         }
 
-        [Test]
+        [RecordedTest]
         public async Task QuerySessions()
         {
             DataFlowClient flowClient = CreateFlowClient();
@@ -104,7 +104,7 @@ public async Task QuerySessions()
         }
 
         [Ignore ("https://github.com/Azure/azure-sdk-for-net/issues/18079 prevents test from working")]
-        [Test]
+        [RecordedTest]
         public async Task ExecuteCommand()
         {
             DataFlowClient flowClient = CreateFlowClient();

diff --git a/sdk/synapse/Azure.Analytics.Synapse.Artifacts/tests/DatasetClientLiveTests.cs b/sdk/synapse/Azure.Analytics.Synapse.Artifacts/tests/DatasetClientLiveTests.cs
@@ -34,7 +34,7 @@ private DatasetClient CreateClient()
             ));
         }
 
-        [Test]
+        [RecordedTest]
         public async Task TestGetDataset()
         {
             DatasetClient client = CreateClient();
@@ -46,7 +46,7 @@ public async Task TestGetDataset()
             }
         }
 
-        [Test]
+        [RecordedTest]
         public async Task TestCreateDataset()
         {
             DatasetClient client = CreateClient();
@@ -57,7 +57,7 @@ public async Task TestCreateDataset()
             Assert.AreEqual(datasetName, dataset.Name);
         }
 
-        [Test]
+        [RecordedTest]
         public async Task TestDeleteDataset()
         {
             DatasetClient client = CreateClient();

diff --git a/sdk/synapse/Azure.Analytics.Synapse.Artifacts/tests/IntegrationRuntimesClientLiveTests.cs b/sdk/synapse/Azure.Analytics.Synapse.Artifacts/tests/IntegrationRuntimesClientLiveTests.cs
@@ -34,7 +34,7 @@ private IntegrationRuntimesClient CreateClient()
             ));
         }
 
-        [Test]
+        [RecordedTest]
         public async Task TestGet()
         {
             IntegrationRuntimesClient client = CreateClient();
@@ -48,7 +48,7 @@ public async Task TestGet()
             }
         }
 
-        [Test]
+        [RecordedTest]
         public async Task TestList()
         {
             IntegrationRuntimesClient client = CreateClient();

diff --git a/sdk/synapse/Azure.Analytics.Synapse.Artifacts/tests/LinkedServiceClientLiveTests.cs b/sdk/synapse/Azure.Analytics.Synapse.Artifacts/tests/LinkedServiceClientLiveTests.cs
@@ -65,7 +65,7 @@ private LinkedServiceClient CreateClient()
             ));
         }
 
-        [Test]
+        [RecordedTest]
         public async Task TestGetLinkedService()
         {
             LinkedServiceClient client = CreateClient();
@@ -83,7 +83,7 @@ public async Task TestGetLinkedService()
             }
         }
 
-        [Test]
+        [RecordedTest]
         public async Task TestDeleteLinkedService()
         {
             LinkedServiceClient client = CreateClient();
@@ -94,7 +94,7 @@ public async Task TestDeleteLinkedService()
             await operation.WaitAndAssertSuccessfulCompletion();
         }
 
-        [Test]
+        [RecordedTest]
         public async Task TestRenameLinkedService()
         {
             LinkedServiceClient client = CreateClient();

diff --git a/sdk/synapse/Azure.Analytics.Synapse.Artifacts/tests/NotebookClientLiveTests.cs b/sdk/synapse/Azure.Analytics.Synapse.Artifacts/tests/NotebookClientLiveTests.cs
@@ -71,7 +71,7 @@ private NotebookClient CreateClient()
             ));
         }
 
-        [Test]
+        [RecordedTest]
         public async Task TestGetNotebook()
         {
             NotebookClient client = CreateClient ();
@@ -89,7 +89,7 @@ public async Task TestGetNotebook()
             }
         }
 
-        [Test]
+        [RecordedTest]
         public async Task TestDeleteNotebook()
         {
             NotebookClient client = CreateClient();
@@ -100,7 +100,7 @@ public async Task TestDeleteNotebook()
             await operation.WaitAndAssertSuccessfulCompletion();
         }
 
-        [Test]
+        [RecordedTest]
         public async Task TestRenameLinkedService()
         {
             NotebookClient client = CreateClient();
@@ -120,7 +120,7 @@ public async Task TestRenameLinkedService()
         }
 
         [Ignore ("https://github.com/Azure/azure-sdk-for-net/issues/18080 - Notebook summary appears to require Synapse.Spark execution first")]
-        [Test]
+        [RecordedTest]
         public async Task TestGetSummary()
         {
             NotebookClient client = CreateClient();

diff --git a/sdk/synapse/Azure.Analytics.Synapse.Artifacts/tests/PipelineClientLiveTests.cs b/sdk/synapse/Azure.Analytics.Synapse.Artifacts/tests/PipelineClientLiveTests.cs
@@ -34,7 +34,7 @@ private PipelineClient CreateClient()
             ));
         }
 
-        [Test]
+        [RecordedTest]
         public async Task TestGetPipeline()
         {
             PipelineClient client = CreateClient ();
@@ -51,7 +51,7 @@ public async Task TestGetPipeline()
             }
         }
 
-        [Test]
+        [RecordedTest]
         public async Task TestDeleteNotebook()
         {
             PipelineClient client = CreateClient();
@@ -62,7 +62,7 @@ public async Task TestDeleteNotebook()
             await operation.WaitAndAssertSuccessfulCompletion();
         }
 
-        [Test]
+        [RecordedTest]
         public async Task TestRenameLinkedService()
         {
             PipelineClient client = CreateClient();
@@ -81,7 +81,7 @@ public async Task TestRenameLinkedService()
             await operation.WaitForCompletionAsync();
         }
 
-        [Test]
+        [RecordedTest]
         public async Task TestPipelineRun()
         {
             PipelineClient client = CreateClient();