-
Notifications
You must be signed in to change notification settings - Fork 4.9k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
[Purview] Design Refactor for Scanning (#20811)
Based on feedback with the C# architects, we've made some changes to the class factoring here and renamed some methods. The goal was to try to reduce the number of clients we have and clean up some naming issues.
- Loading branch information
Showing
19 changed files
with
1,452 additions
and
1,651 deletions.
There are no files selected for viewing
209 changes: 91 additions & 118 deletions
209
...w/Azure.Analytics.Purview.Scanning/api/Azure.Analytics.Purview.Scanning.netstandard2.0.cs
Large diffs are not rendered by default.
Oops, something went wrong.
18 changes: 18 additions & 0 deletions
18
...ew/Azure.Analytics.Purview.Scanning/src/Customizations/PurviewClassificationRuleClient.cs
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,18 @@ | ||
// Copyright (c) Microsoft Corporation. All rights reserved. | ||
// Licensed under the MIT License. | ||
|
||
using System; | ||
using Azure.Core.Pipeline; | ||
|
||
namespace Azure.Analytics.Purview.Scanning | ||
{ | ||
public partial class PurviewClassificationRuleClient | ||
{ | ||
internal PurviewClassificationRuleClient(Uri endpoint, string classificationRuleName, HttpPipeline pipeline, string apiVersion) { | ||
this.endpoint = endpoint; | ||
this.Pipeline = pipeline; | ||
this.classificationRuleName = classificationRuleName; | ||
this.apiVersion = apiVersion; | ||
} | ||
} | ||
} |
21 changes: 21 additions & 0 deletions
21
sdk/purview/Azure.Analytics.Purview.Scanning/src/Customizations/PurviewDataSourceClient.cs
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,21 @@ | ||
// Copyright (c) Microsoft Corporation. All rights reserved. | ||
// Licensed under the MIT License. | ||
|
||
using System; | ||
using Azure.Core.Pipeline; | ||
|
||
namespace Azure.Analytics.Purview.Scanning | ||
{ | ||
public partial class PurviewDataSourceClient | ||
{ | ||
internal PurviewDataSourceClient(Uri endpoint, string dataSourceName, HttpPipeline pipeline, string apiVersion) { | ||
this.endpoint = endpoint; | ||
this.dataSourceName= dataSourceName; | ||
this.Pipeline = pipeline; | ||
this.apiVersion = apiVersion; | ||
} | ||
|
||
/// <summary /> | ||
public PurviewScanClient GetScanClient(string scanName) => new PurviewScanClient(endpoint, dataSourceName, scanName, Pipeline, apiVersion); | ||
} | ||
} |
19 changes: 19 additions & 0 deletions
19
sdk/purview/Azure.Analytics.Purview.Scanning/src/Customizations/PurviewScanClient.cs
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,19 @@ | ||
// Copyright (c) Microsoft Corporation. All rights reserved. | ||
// Licensed under the MIT License. | ||
|
||
using System; | ||
using Azure.Core.Pipeline; | ||
|
||
namespace Azure.Analytics.Purview.Scanning | ||
{ | ||
public partial class PurviewScanClient | ||
{ | ||
internal PurviewScanClient(Uri endpoint, string dataSourceName, string scanName, HttpPipeline pipeline, string apiVersion) { | ||
this.endpoint = endpoint; | ||
this.dataSourceName= dataSourceName; | ||
this.scanName = scanName; | ||
this.Pipeline = pipeline; | ||
this.apiVersion = apiVersion; | ||
} | ||
} | ||
} |
14 changes: 14 additions & 0 deletions
14
sdk/purview/Azure.Analytics.Purview.Scanning/src/Customizations/PurviewScanningClient.cs
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,14 @@ | ||
// Copyright (c) Microsoft Corporation. All rights reserved. | ||
// Licensed under the MIT License. | ||
|
||
namespace Azure.Analytics.Purview.Scanning | ||
{ | ||
public partial class PurviewScanningServiceClient | ||
{ | ||
/// <summary /> | ||
public PurviewDataSourceClient GetDataSourceClient(string dataSourceName) => new PurviewDataSourceClient(endpoint, dataSourceName, Pipeline, apiVersion); | ||
|
||
/// <summary /> | ||
public PurviewClassificationRuleClient GetClassificationRuleClient(string classificationRuleName) => new PurviewClassificationRuleClient(endpoint, classificationRuleName, Pipeline, apiVersion); | ||
} | ||
} |
195 changes: 0 additions & 195 deletions
195
sdk/purview/Azure.Analytics.Purview.Scanning/src/Generated/AzureKeyVaultsClient.cs
This file was deleted.
Oops, something went wrong.
85 changes: 0 additions & 85 deletions
85
sdk/purview/Azure.Analytics.Purview.Scanning/src/Generated/DataSourceClient.cs
This file was deleted.
Oops, something went wrong.
Oops, something went wrong.