Update Remove to TryRemove for ConcurrentDictionary in Transfermanager (

#47038)
Azure · Nov 8, 2024 · 8a63175 · 8a63175
1 parent af5ccc6
commit 8a63175
Showing 1 changed file with 3 additions and 1 deletion.
diff --git a/sdk/storage/Azure.Storage.DataMovement/src/TransferManager.cs b/sdk/storage/Azure.Storage.DataMovement/src/TransferManager.cs
@@ -392,7 +392,9 @@ await _checkpointer.AddNewJobAsync(
                 // cleanup any state for a job that didn't even start
                 try
                 {
-                    _dataTransfers.Remove(transferId);
+                    // No need to check if we were able to remove the transfer or not.
+                    // If there's no stale DataTransfer to remove, move on, because this is a cleanup
+                    _dataTransfers.TryRemove(transferId, out DataTransfer transfer);
                     await _checkpointer.TryRemoveStoredTransferAsync(transferId, cancellationToken).ConfigureAwait(false);
                 }
                 catch (Exception cleanupEx)