Skip to content

Commit

Permalink
[Service Bus] Fix sender identifier generation (#47346)
Browse files Browse the repository at this point in the history
The focus of these changes is to fix a bug causing identifier generation for
`ServiceBusSender` to not include the entity path as informational context.
  • Loading branch information
jsquire authored Nov 27, 2024
1 parent 664b5fd commit 50ecf57
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 1 deletion.
2 changes: 2 additions & 0 deletions sdk/servicebus/Azure.Messaging.ServiceBus/CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,8 @@

### Bugs Fixed

- Fixed an issue where identifier generation for senders did not correctly include the entity path as an informational element. ([#46952](https://github.com/Azure/azure-sdk-for-net/issues/46952))

### Other Changes

- Added annotations to make the package compatible with trimming and native AOT compilation.
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -119,7 +119,7 @@ internal ServiceBusSender(
Argument.AssertNotNullOrWhiteSpace(entityPath, nameof(entityPath));
connection.ThrowIfClosed();

var identifier = string.IsNullOrEmpty(options?.Identifier) ? DiagnosticUtilities.GenerateIdentifier(EntityPath) : options.Identifier;
var identifier = string.IsNullOrEmpty(options?.Identifier) ? DiagnosticUtilities.GenerateIdentifier(entityPath) : options.Identifier;

EntityPath = entityPath;
Identifier = identifier;
Expand Down

0 comments on commit 50ecf57

Please sign in to comment.