Skip to content

Commit

Permalink
Renames, Delete swallows 404s, Add StringFormatter overloads to Query…
Browse files Browse the repository at this point in the history
… methods (#20786)

* renames
* catch 404s
* string format overloads for Query methods
  • Loading branch information
christothes authored May 4, 2021
1 parent 82c7aff commit 4ac1a47
Show file tree
Hide file tree
Showing 44 changed files with 1,399 additions and 920 deletions.
2 changes: 1 addition & 1 deletion sdk/tables/Azure.Data.Tables/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -119,7 +119,7 @@ The set of existing Azure tables can be queries using an OData filter.
```C# Snippet:TablesSample3QueryTables
// Use the <see cref="TableServiceClient"> to query the service. Passing in OData filter strings is optional.
Pageable<TableItem> queryTableResults = serviceClient.GetTables(filter: $"TableName eq '{tableName}'");
Pageable<TableItem> queryTableResults = serviceClient.Query(filter: $"TableName eq '{tableName}'");

Console.WriteLine("The following are the names of the tables in the query results:");

Expand Down

Large diffs are not rendered by default.

2 changes: 1 addition & 1 deletion sdk/tables/Azure.Data.Tables/samples/Sample3QueryTables.md
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@ To get a collection of tables, call `GetTables` and optionally pass in an OData
```C# Snippet:TablesSample3QueryTables
// Use the <see cref="TableServiceClient"> to query the service. Passing in OData filter strings is optional.
Pageable<TableItem> queryTableResults = serviceClient.GetTables(filter: $"TableName eq '{tableName}'");
Pageable<TableItem> queryTableResults = serviceClient.Query(filter: $"TableName eq '{tableName}'");

Console.WriteLine("The following are the names of the tables in the query results:");

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -8,35 +8,35 @@
namespace Microsoft.Extensions.Azure
{
/// <summary>
/// Extension methods to add <see cref="TableClientOptions"/> client to clients builder.
/// Extension methods to add <see cref="TablesClientOptions"/> client to clients builder.
/// </summary>
public static class TableClientBuilderExtensions
{
/// <summary>
/// Registers a <see cref="TableServiceClient"/> instance with the provided <paramref name="connectionString"/>
/// </summary>
public static IAzureClientBuilder<TableServiceClient, TableClientOptions> AddTableServiceClient<TBuilder>(this TBuilder builder, string connectionString)
public static IAzureClientBuilder<TableServiceClient, TablesClientOptions> AddTableServiceClient<TBuilder>(this TBuilder builder, string connectionString)
where TBuilder : IAzureClientFactoryBuilder
{
return builder.RegisterClientFactory<TableServiceClient, TableClientOptions>(options => new TableServiceClient(connectionString, options));
return builder.RegisterClientFactory<TableServiceClient, TablesClientOptions>(options => new TableServiceClient(connectionString, options));
}

/// <summary>
/// Registers a <see cref="TableServiceClient"/> instance with the provided <paramref name="serviceUri"/> and <paramref name="sharedKeyCredential"/>
/// </summary>
public static IAzureClientBuilder<TableServiceClient, TableClientOptions> AddTableServiceClient<TBuilder>(this TBuilder builder, Uri serviceUri, TableSharedKeyCredential sharedKeyCredential)
public static IAzureClientBuilder<TableServiceClient, TablesClientOptions> AddTableServiceClient<TBuilder>(this TBuilder builder, Uri serviceUri, TableSharedKeyCredential sharedKeyCredential)
where TBuilder : IAzureClientFactoryBuilder
{
return builder.RegisterClientFactory<TableServiceClient, TableClientOptions>(options => new TableServiceClient(serviceUri, sharedKeyCredential, options));
return builder.RegisterClientFactory<TableServiceClient, TablesClientOptions>(options => new TableServiceClient(serviceUri, sharedKeyCredential, options));
}

/// <summary>
/// Registers a <see cref="TableServiceClient"/> instance with connection options loaded from the provided <paramref name="configuration"/> instance.
/// </summary>
public static IAzureClientBuilder<TableServiceClient, TableClientOptions> AddTableServiceClient<TBuilder, TConfiguration>(this TBuilder builder, TConfiguration configuration)
public static IAzureClientBuilder<TableServiceClient, TablesClientOptions> AddTableServiceClient<TBuilder, TConfiguration>(this TBuilder builder, TConfiguration configuration)
where TBuilder : IAzureClientFactoryBuilderWithConfiguration<TConfiguration>
{
return builder.RegisterClientFactory<TableServiceClient, TableClientOptions>(configuration);
return builder.RegisterClientFactory<TableServiceClient, TablesClientOptions>(configuration);
}
}
}

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Loading

0 comments on commit 4ac1a47

Please sign in to comment.