Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Storage] Flattening Client Hierarchy - storage-queue #5579

Merged
merged 13 commits into from
Oct 16, 2019
Merged

[Storage] Flattening Client Hierarchy - storage-queue #5579

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
13 commits
Select commit Hold shift + click to select a range
874ad47
QueueClient is flattened into QSC, MC is renamed to QC, MidC is flatt…
HarshaNalluru Oct 15, 2019
d395f0d
remove MessageIdClient
HarshaNalluru Oct 15, 2019
f1c66d2
resolve merge conflicts with upstream/master
HarshaNalluru Oct 15, 2019
ac690d2
final version of QSC
HarshaNalluru Oct 15, 2019
1aea0be
bring back the old QSC constructor
HarshaNalluru Oct 15, 2019
79d6107
Final version of QueueClient
HarshaNalluru Oct 15, 2019
8dfc312
Fix getQueueClient method
HarshaNalluru Oct 15, 2019
be1c223
_messagesUrl private field for convenience
HarshaNalluru Oct 16, 2019
98fe74c
fix the tests
HarshaNalluru Oct 16, 2019
0d6c792
refactor - getStorageClientContext
HarshaNalluru Oct 16, 2019
83ce887
Add createQueue and deleteQueue methods on QSC
HarshaNalluru Oct 16, 2019
8b194b9
added a test and recordings
HarshaNalluru Oct 16, 2019
a160cde
new names - sendMessage() and receiveMessages()
HarshaNalluru Oct 16, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
106 changes: 106 additions & 0 deletions ...queue/recordings/browsers/queueserviceclient/recording_can_create_and_delete_a_queue.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,106 @@
{
"recordings": [
{
"method": "PUT",
"url": "https://fakestorageaccount.queue.core.windows.net/queue157120301266007758",
"query": {
"timeout": "30"
},
"requestBody": null,
"status": 201,
"response": "",
"responseHeaders": {
"date": "Wed, 16 Oct 2019 05:16:52 GMT",
"server": "Windows-Azure-Queue/1.0 Microsoft-HTTPAPI/2.0",
"x-ms-request-id": "03f6ae9a-9003-0051-27e0-837809000000",
"x-ms-version": "2019-02-02",
"x-ms-client-request-id": "62b4caeb-39d3-4160-ab10-1510b60bcd3f",
"content-length": "0"
}
},
{
"method": "PUT",
"url": "https://fakestorageaccount.queue.core.windows.net/queue157120301266007758",
"query": {
"comp": "metadata",
"timeout": "30"
},
"requestBody": null,
"status": 204,
"response": "",
"responseHeaders": {
"date": "Wed, 16 Oct 2019 05:16:52 GMT",
"server": "Windows-Azure-Queue/1.0 Microsoft-HTTPAPI/2.0",
"x-ms-request-id": "03f6aea5-9003-0051-2ee0-837809000000",
"x-ms-version": "2019-02-02",
"x-ms-client-request-id": "73bd9ffe-7d47-4189-887b-ff9e3d20c87f",
"content-length": "0"
}
},
{
"method": "GET",
"url": "https://fakestorageaccount.queue.core.windows.net/queue157120301266007758",
"query": {
"comp": "metadata",
"timeout": "30"
},
"requestBody": null,
"status": 200,
"response": "",
"responseHeaders": {
"x-ms-meta-keya": "vala",
"date": "Wed, 16 Oct 2019 05:16:52 GMT",
"server": "Windows-Azure-Queue/1.0 Microsoft-HTTPAPI/2.0",
"x-ms-approximate-messages-count": "0",
"x-ms-request-id": "03f6aec1-9003-0051-3ae0-837809000000",
"cache-control": "no-cache",
"x-ms-meta-key0": "val0",
"x-ms-version": "2019-02-02",
"x-ms-client-request-id": "1b18fe96-5ba4-45b7-81b6-3697b465d4d3",
"content-length": "0"
}
},
{
"method": "DELETE",
"url": "https://fakestorageaccount.queue.core.windows.net/queue157120301266007758",
"query": {
"timeout": "30"
},
"requestBody": null,
"status": 204,
"response": "",
"responseHeaders": {
"date": "Wed, 16 Oct 2019 05:16:52 GMT",
"server": "Windows-Azure-Queue/1.0 Microsoft-HTTPAPI/2.0",
"x-ms-request-id": "03f6aecf-9003-0051-41e0-837809000000",
"x-ms-version": "2019-02-02",
"x-ms-client-request-id": "df0e3862-9f86-4ac9-9971-b9338fce8bcb",
"content-length": "0"
}
},
{
"method": "GET",
"url": "https://fakestorageaccount.queue.core.windows.net/queue157120301266007758",
"query": {
"comp": "metadata",
"timeout": "30"
},
"requestBody": null,
"status": 404,
"response": "<?xml version=\"1.0\" encoding=\"utf-8\"?><Error><Code>QueueNotFound</Code><Message>The specified queue does not exist.\nRequestId:03f6aef1-9003-0051-52e0-837809000000\nTime:2019-10-16T05:16:53.8843350Z</Message></Error>",
"responseHeaders": {
"date": "Wed, 16 Oct 2019 05:16:52 GMT",
"server": "Windows-Azure-Queue/1.0 Microsoft-HTTPAPI/2.0",
"x-ms-error-code": "QueueNotFound",
"content-type": "application/xml",
"x-ms-request-id": "03f6aef1-9003-0051-52e0-837809000000",
"x-ms-version": "2019-02-02",
"x-ms-client-request-id": "2db491bb-975f-41fa-aa6b-87681c6eccfd",
"content-length": "217"
}
}
],
"uniqueTestInfo": {
"queue": "queue157120301266007758"
}
}
118 changes: 118 additions & 0 deletions ...orage-queue/recordings/node/queueserviceclient/recording_can_create_and_delete_a_queue.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,118 @@
let nock = require('nock');

module.exports.testInfo = {"queue":"queue157120298759201536"}

nock('https://fakestorageaccount.queue.core.windows.net:443', {"encodedQueryParams":true})
.put('/queue157120298759201536')
.query(true)
.reply(201, "", [ 'Content-Length',
'0',
'Server',
'Windows-Azure-Queue/1.0 Microsoft-HTTPAPI/2.0',
'x-ms-request-id',
'f52f157a-f003-0068-74e0-8338ad000000',
'x-ms-client-request-id',
'6e42f940-584a-4629-a18d-272e77bad19a',
'x-ms-version',
'2019-02-02',
'Date',
'Wed, 16 Oct 2019 05:16:27 GMT',
'Connection',
'close' ]);


nock('https://fakestorageaccount.queue.core.windows.net:443', {"encodedQueryParams":true})
.put('/queue157120298759201536')
.query(true)
.reply(204, "", [ 'Content-Length',
'0',
'Server',
'Windows-Azure-Queue/1.0 Microsoft-HTTPAPI/2.0',
'x-ms-request-id',
'1a6f3221-a003-0059-40e0-83637a000000',
'x-ms-client-request-id',
'1b8aeb34-56be-4dba-9cec-a0382386b696',
'x-ms-version',
'2019-02-02',
'Date',
'Wed, 16 Oct 2019 05:16:28 GMT',
'Connection',
'close' ]);


nock('https://fakestorageaccount.queue.core.windows.net:443', {"encodedQueryParams":true})
.get('/queue157120298759201536')
.query(true)
.reply(200, "", [ 'Cache-Control',
'no-cache',
'Content-Length',
'0',
'Server',
'Windows-Azure-Queue/1.0 Microsoft-HTTPAPI/2.0',
'x-ms-request-id',
'4b190980-0003-0010-14e0-83501a000000',
'x-ms-client-request-id',
'ccca71d9-915d-4687-a391-9acce33aa341',
'x-ms-version',
'2019-02-02',
'x-ms-approximate-messages-count',
'0',
'x-ms-meta-key0',
'val0',
'x-ms-meta-keya',
'vala',
'Access-Control-Expose-Headers',
'x-ms-request-id,x-ms-client-request-id,Server,x-ms-version,x-ms-approximate-messages-count,Cache-Control,x-ms-meta-key0,x-ms-meta-keya,Content-Length,Date,Transfer-Encoding',
'Access-Control-Allow-Origin',
'*',
'Date',
'Wed, 16 Oct 2019 05:16:27 GMT',
'Connection',
'close' ]);


nock('https://fakestorageaccount.queue.core.windows.net:443', {"encodedQueryParams":true})
.delete('/queue157120298759201536')
.query(true)
.reply(204, "", [ 'Content-Length',
'0',
'Server',
'Windows-Azure-Queue/1.0 Microsoft-HTTPAPI/2.0',
'x-ms-request-id',
'89b4015f-5003-0065-03e0-83d7a1000000',
'x-ms-client-request-id',
'08a6c594-771b-4e94-8ed6-839b7461e9e0',
'x-ms-version',
'2019-02-02',
'Date',
'Wed, 16 Oct 2019 05:16:28 GMT',
'Connection',
'close' ]);


nock('https://fakestorageaccount.queue.core.windows.net:443', {"encodedQueryParams":true})
.get('/queue157120298759201536')
.query(true)
.reply(404, "<?xml version=\"1.0\" encoding=\"utf-8\"?><Error><Code>QueueNotFound</Code><Message>The specified queue does not exist.\nRequestId:2f3ca484-b003-002b-7be0-831244000000\nTime:2019-10-16T05:16:29.5328512Z</Message></Error>", [ 'Content-Length',
'217',
'Content-Type',
'application/xml',
'Server',
'Windows-Azure-Queue/1.0 Microsoft-HTTPAPI/2.0',
'x-ms-request-id',
'2f3ca484-b003-002b-7be0-831244000000',
'x-ms-client-request-id',
'134b6c93-0cee-42b9-861d-b8c2a4130e7c',
'x-ms-version',
'2019-02-02',
'x-ms-error-code',
'QueueNotFound',
'Access-Control-Expose-Headers',
'x-ms-request-id,x-ms-client-request-id,Server,x-ms-version,x-ms-error-code,Content-Length,Date,Transfer-Encoding',
'Access-Control-Allow-Origin',
'*',
'Date',
'Wed, 16 Oct 2019 05:16:29 GMT',
'Connection',
'close' ]);

Loading