[Storage] Imports @azure/abort-controller - storage-queue
#4359
Conversation
There was a problem hiding this comment.
Looks good. In master branch, storage SDKs depend on "ms-rest-js". Now ms-rest-js updated to "2.0.0" which incroduces AborterSignal breaking changes. See this https://github.com/Azure/ms-rest-js/blob/master/Changelog.md#200---2019-06-21 In next storage feature release from master branch, I'm going to update to @azure/ms-rest-js@v2 version.
Any plan to align with latest @azure/ms-rest-js in @azure/core-http? Otherwise, there will be conflicts when merging master and storage/feature branch toghether.
|
OMG. Thanks for the heads up. In case that is necessary.. @daviwil, is there any plan to align with the latest |
|
Yep, I need to pull over those changes for preview.2. I'll look into whether I can get that done tomorrow. |
@HarshaNalluru ms-rest-js@v2 dropped axios and updated to node-fetch due to axios's long response for issues like proxy support. ms-rest-js@v2 also supports keep-alive which will help improve storage SDK's performance especially for tiny requests. Due to ms-rest-js@v2's AborterSignal interface breaking change (seems in order to align with AbortSignal standards), @azure/abort-controller needs to take these changes too. |
| @@ -3,7 +3,7 @@ | |||
|
|
|||
| import { TokenCredential, isTokenCredential, isNode } from "@azure/core-http"; | |||
| import * as Models from "./generated/lib/models"; | |||
| import { Aborter } from "./Aborter"; | |||
| import { AbortSignal } from "@azure/abort-controller"; | |||
There was a problem hiding this comment.
In our other SDKs we're using the AbortSignalLike interface from @azure/abort-controller as the type for abortSignal, instead of the AbortSignal class. This is so customers can also use the native AbortController/AbortSignal built into modern web-browsers as well.
There was a problem hiding this comment.
Here's an example in event-hubs: https://github.com/Azure/azure-sdk-for-js/blob/master/sdk/eventhub/event-hubs/src/receiver.ts#L272
Update storage-queue to use the @azure/aborter-controller library and remove the existing Aborter from the src folder, updates tests, recordings, changelog accordingly.