Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[translation] Migrate translation projects to use snippets extraction #33220

Merged
merged 36 commits into from
Feb 27, 2025

Conversation

mpodwysocki
Copy link
Member

@mpodwysocki mpodwysocki commented Feb 26, 2025

Packages impacted by this PR

  • @azure-rest/ai-translation-document
  • @azure-rest/ai-translation-text

Issues associated with this PR

Describe the problem that is addressed by this PR

Updates all projects under translation to use snippets extraction. Note this disables non-functioning tests that need to be recorded under the documentTranslationTest.spec.ts and translationFilterTest.spec.ts. Noted in the issue #31948 that the tests need to be re-recorded.

What are the possible designs available to address the problem? If there are more than one possible design, why was the one in this PR chosen?

Are there test cases added in this PR? (If not, why?)

Provide a list of related PRs (if any)

Command used to generate this PR:**(Applicable only to SDK release request PRs)

Checklists

  • Added impacted package name to the issue description
  • Does this PR needs any fixes in the SDK Generator?** (If so, create an Issue in the Autorest/typescript repository and link it here)
  • Added a changelog (if necessary)

@azure-sdk
Copy link
Collaborator

API change check

API changes are not detected in this pull request.

@mpodwysocki mpodwysocki merged commit 82343df into main Feb 27, 2025
19 checks passed
@mpodwysocki mpodwysocki deleted the feat/translation-snippets branch February 27, 2025 16:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants