Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[schemaregistry] Migrate schemaregistry projects to use snippets extraction #33193

Merged
merged 36 commits into from
Feb 26, 2025

Conversation

mpodwysocki
Copy link
Member

Packages impacted by this PR

  • @azure/schema-registry
  • @azure/schema-registry-avro
  • @azure/schema-registry-json

Issues associated with this PR

Describe the problem that is addressed by this PR

Updates all projects under schemaregistry to use snippets extraction.

What are the possible designs available to address the problem? If there are more than one possible design, why was the one in this PR chosen?

Are there test cases added in this PR? (If not, why?)

Provide a list of related PRs (if any)

Command used to generate this PR:**(Applicable only to SDK release request PRs)

Checklists

  • Added impacted package name to the issue description
  • Does this PR needs any fixes in the SDK Generator?** (If so, create an Issue in the Autorest/typescript repository and link it here)
  • Added a changelog (if necessary)

@azure-sdk
Copy link
Collaborator

API change check

API changes are not detected in this pull request.

Copy link
Member

@deyaaeldeen deyaaeldeen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I left a couple comments but man, I love the snippet changes, thank you!

Copy link
Member

@minhanh-phan minhanh-phan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for this awesome work 💯

@mpodwysocki mpodwysocki merged commit 8c67ad6 into main Feb 26, 2025
21 checks passed
@mpodwysocki mpodwysocki deleted the feat/schemaregistry-snippets branch February 26, 2025 21:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants