-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[schemaregistry] Migrate schemaregistry projects to use snippets extraction #33193
Conversation
API change check API changes are not detected in this pull request. |
sdk/schemaregistry/schema-registry-json/vitest.browser.config.ts
Outdated
Show resolved
Hide resolved
sdk/schemaregistry/schema-registry-avro/vitest.browser.config.ts
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I left a couple comments but man, I love the snippet changes, thank you!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for this awesome work 💯
Packages impacted by this PR
Issues associated with this PR
Describe the problem that is addressed by this PR
Updates all projects under
schemaregistry
to use snippets extraction.What are the possible designs available to address the problem? If there are more than one possible design, why was the one in this PR chosen?
Are there test cases added in this PR? (If not, why?)
Provide a list of related PRs (if any)
Command used to generate this PR:**(Applicable only to SDK release request PRs)
Checklists