Enable rollup for browser with sample #3206
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ramya-rao-a
suggested changes
May 25, 2019
bterlson
approved these changes
May 28, 2019
ramya-rao-a
reviewed
May 28, 2019
|
|
||
| <script> | ||
| // EventHubClient holds reference to the EventHubClient global object exposed by the imported script | ||
| const EventHubClient = Azure.Messaging.EventHub.EventHubClient; |
There was a problem hiding this comment.
Did you test this sample with the latest changes in this PR? Shouldnt Azure.Messaging.EventHub be Azure.Messaging.EventHubs
There was a problem hiding this comment.
Yes, I think I had edited it before pushing. Tested before pushing latest changes.
ramya-rao-a
approved these changes
May 28, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For more context refer to #2808
Verified manually by running in browser and checking EventHub entity