[Event Hubs] Allow users to configure retry options in send requests #2997
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ure-sdk-for-js into update_sendRetry
ramya-rao-a
suggested changes
May 20, 2019
| @@ -581,8 +585,11 @@ export class EventHubSender extends LinkEntity { | |||
| operation: sendEventPromise, | |||
| connectionId: this._context.connectionId, | |||
| operationType: RetryOperationType.sendMessage, | |||
| times: Constants.defaultRetryAttempts, | |||
| delayInSeconds: Constants.defaultDelayBetweenOperationRetriesInSeconds + jitterInSeconds | |||
| times: options && options.retryAttempts ? options.retryAttempts : Constants.defaultRetryAttempts, | |||
There was a problem hiding this comment.
options && options.retryAttempts is "falsy", if the provided value was 0.
Use the user provided value only if it is greater than 0.
Check with @bterlson if we want retryAttempts as exposed to the user to mean the total number of attempts or the number of attempts after the first failure
ramya-rao-a
approved these changes
May 20, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allow users to configure retry options in send requests as described in #2661 (comment) for send operations on
EventHubClient.