Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[engsys] fix indentation in policheck.yml #29359

Closed
wants to merge 1 commit into from
Closed

[engsys] fix indentation in policheck.yml #29359

wants to merge 1 commit into from

Conversation

jeremymeng
Copy link
Member

No description provided.

@jeremymeng jeremymeng marked this pull request as ready for review April 18, 2024 20:08
@jeremymeng
Copy link
Member Author

template pipeline failures are unrelated.

@jeremymeng
Copy link
Member Author

passing run https://dev.azure.com/azure-sdk/internal/_build/results?buildId=3711269&view=results (MS INTERNAL)

weshaggard
weshaggard requested changes Apr 18, 2024
View reviewed changes
Copy link
Member

@weshaggard weshaggard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This would need to be fixed in tools. I had tested this in JS so I'm not sure how this indention got added.

@jeremymeng jeremymeng enabled auto-merge (squash) April 18, 2024 21:25
@jeremymeng jeremymeng closed this Apr 18, 2024
auto-merge was automatically disabled April 18, 2024 21:26

Pull request was closed

@weshaggard
Copy link
Member

Azure/azure-sdk-tools#8126

@jeremymeng
Copy link
Member Author

This would need to be fixed in tools. I had tested this in JS so I'm not sure how this indention got added.

opened PR Azure/azure-sdk-tools#8127

@weshaggard
Copy link
Member

Thanks for calling this to my attention @jeremymeng

@jeremymeng jeremymeng deleted the engsys/fix-polick-yml branch April 19, 2024 01:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@weshaggard weshaggard weshaggard requested changes

@benbp benbp benbp approved these changes

@ckairen ckairen Awaiting requested review from ckairen

@mikeharder mikeharder Awaiting requested review from mikeharder

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jeremymeng @weshaggard @benbp