Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resolving promises before returning from the method in Storage SDK #25096

Closed
wants to merge 3 commits into from

Conversation

kotewar
Copy link
Member

@kotewar kotewar commented Mar 6, 2023

Packages impacted by this PR

@azure/storage-blob

Issues associated with this PR

Describe the problem that is addressed by this PR

Sometimes download gets hanged when trying to download a file from the Azure blob storage using the SDK. This is intermittent but we noticed the promises were not resolved at places and suspecting some corner case when concurrency is enabled that could be causing this. Hence resolving promises and added corner conditions just to be extra cautious.

What are the possible designs available to address the problem? If there are more than one possible design, why was the one in this PR chosen?

Used the existing design pattern to fix the bug

Are there test cases added in this PR? (If not, why?)

Provide a list of related PRs (if any)

Command used to generate this PR:**(Applicable only to SDK release request PRs)

Checklists

  • Added impacted package name to the issue description
  • Does this PR needs any fixes in the SDK Generator?** (If so, create an Issue in the Autorest/typescript repository and link it here)
  • Added a changelog (if necessary)

@ghost ghost added Storage Storage Service (Queues, Blobs, Files) customer-reported Issues that are reported by GitHub users external to the Azure organization. labels Mar 6, 2023
@ghost
Copy link

ghost commented Mar 6, 2023

Thank you for your contribution kotewar! We will review the pull request and get back to you soon.

@kotewar kotewar changed the title Resolving promises before returning Resolving promises before returning from the method in Storage SDK Mar 6, 2023
@jeremymeng jeremymeng added the Client This issue points to a problem in the data-plane of the library. label Mar 21, 2023
@github-actions
Copy link

Hi @kotewar. Thank you for your interest in helping to improve the Azure SDK experience and for your contribution. We've noticed that there hasn't been recent engagement on this pull request. If this is still an active work stream, please let us know by pushing some changes or leaving a comment. Otherwise, we'll close this out in 7 days.

@github-actions github-actions bot added the no-recent-activity There has been no recent activity on this issue. label May 26, 2023
@kotewar kotewar closed this May 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Client This issue points to a problem in the data-plane of the library. customer-reported Issues that are reported by GitHub users external to the Azure organization. no-recent-activity There has been no recent activity on this issue. Storage Storage Service (Queues, Blobs, Files)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants