Resolving promises before returning from the method in Storage SDK #25096
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Packages impacted by this PR
@azure/storage-blob
Issues associated with this PR
Describe the problem that is addressed by this PR
Sometimes download gets hanged when trying to download a file from the Azure blob storage using the SDK. This is intermittent but we noticed the promises were not resolved at places and suspecting some corner case when concurrency is enabled that could be causing this. Hence resolving promises and added corner conditions just to be extra cautious.
What are the possible designs available to address the problem? If there are more than one possible design, why was the one in this PR chosen?
Used the existing design pattern to fix the bug
Are there test cases added in this PR? (If not, why?)
Provide a list of related PRs (if any)
Command used to generate this PR:**(Applicable only to SDK release request PRs)
Checklists