Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Azure Lab Services Sample Issue #22063

Closed
wants to merge 1 commit into from
Closed

Fix Azure Lab Services Sample Issue #22063

wants to merge 1 commit into from

Conversation

zzhxiaofeng
Copy link
Contributor

@zzhxiaofeng zzhxiaofeng commented Jun 1, 2022 •
edited by v-xuto
Loading

Fixes #20663

@joheredi , @qiaozha, @dw511214992, @MaryGao for notification.

@ghost ghost added the Mgmt This issue is related to a management-plane library. label Jun 1, 2022
@azure-sdk
Copy link
Collaborator

API change check

API changes are not detected in this pull request.

@zzhxiaofeng zzhxiaofeng marked this pull request as ready for review June 1, 2022 10:10
@v-xuto
Copy link
Member

v-xuto commented Jun 6, 2022

@joheredi , @qiaozha, @dw511214992 and @MaryGao Could you please review this PR? Thanks a lot.

@qiaozha
Copy link
Member

qiaozha commented Jun 6, 2022

@v-xuto It's not that I don't want to fix this issue but those samples are all auto generated from swagger sample https://github.com/Azure/azure-sdk-for-js/pull/22063/files#diff-ea5da669c7be33af825f2df546fb0f5416eb436558b446a80c3b3538197fdbdeL15 see the x-ms-original-file value here https://github.com/Azure/azure-rest-api-specs/blob/main/specification/labservices/resource-manager/Microsoft.LabServices/preview/2021-11-15-preview/examples/Labs/putLab.json. Even if we fixed it here, the next time we generate the SDK those fixes would be overwrite. The right way to handle those sample value is to file a PR in rest api specs to fix those example directly and then refresh SDK generation.

@qiaozha qiaozha mentioned this pull request Jun 7, 2022
Closed
@v-xuto
Copy link
Member

v-xuto commented Jun 8, 2022

@qiaozha Okay, I agree with your opinion. We will close this PR, and wait for you to file a PR in rest api specs to fix this issue.
Is that OK?

@v-xuto v-xuto closed this Jun 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@qiaozha qiaozha Awaiting requested review from qiaozha qiaozha is a code owner

@dw511214992 dw511214992 Awaiting requested review from dw511214992

@MaryGao MaryGao Awaiting requested review from MaryGao MaryGao is a code owner

Assignees
No one assigned
Labels
Mgmt This issue is related to a management-plane library.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Azure Lab Services Sample Issue
4 participants
@zzhxiaofeng @azure-sdk @v-xuto @qiaozha