Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

November Release Changes #18530

Merged

Conversation

sarangan12
Copy link
Contributor

This PR consists of some renames that are to be included in the search documents SDK for November release.

@xirzec Please review and approve the PR.

@sarangan12 sarangan12 requested a review from xirzec November 4, 2021 08:04
@ghost ghost added the Search label Nov 4, 2021
@azure-sdk
Copy link
Collaborator

API changes have been detected in @azure/search-documents. You can review API changes here

Copy link
Member

@xirzec xirzec left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The API changes look good! My only open question is if we could do some of this with swagger transforms instead of needing to translate the shapes back and forth.

@sarangan12 sarangan12 merged commit 9968540 into Azure:main Nov 4, 2021
sadasant pushed a commit to sadasant/azure-sdk-for-js that referenced this pull request Nov 6, 2021
* November Release Changes

* Optimize through Swagger Overrides
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants