Use docker to validate packages in js docindex #18405
Conversation
b5feeb7 to
eaef568
Compare
There was a problem hiding this comment.
One relatively small change and I think we're good here. We do need to support folder so we don't unnecessarily remove packages from onboarding.
A trip down memory lane: This is the first pipeline for which I built package validation. It performs validation against ALL packages. This means we can expect the runtime of this pipeline to be more than 30 minutes given that we have to pass through the validation process twice (once for regular onboarding updates in main and again in the daily docs branch)... For now we can push the start time for the pipeline back but run time will continue to grow linearly as we add more packages... Fortunately the other 3 cardinal languages do not have this problem.
The long term fix is already opened here: #16626
Azure/azure-sdk-for-js#18405 Docs is switching the validation using docker container. Here is the common logic to pull image from Azure container register. Testing pipeline in use with the script: https://dev.azure.com/azure-sdk/internal/_build/results?buildId=1172146&view=logs&j=dc056dfc-c0cf-5958-c8c4-8da4f91a3739&t=bfb6cede-7671-5504-0a11-79b13ef63703
|
/check-enforcer override |
|
@danieljurek do you have time to review the PR? I will merge it after a test run and keep an eye on the performance once gets check in if no further response. |
|
Done with testing. Testing link pasted in description. |
We plan to wrap the CI build command into docker image and use it to validate packages in docker.
The PR is to replace the sanity check first. Will have a follow up PR for creating issues whenever the package got filtered out.
Here is the testing pipeline:
https://dev.azure.com/azure-sdk/internal/_build/results?buildId=1174856&view=logs&j=dc056dfc-c0cf-5958-c8c4-8da4f91a3739
Test on no image id:
https://dev.azure.com/azure-sdk/internal/_build/results?buildId=1180723&view=logs&j=dc056dfc-c0cf-5958-c8c4-8da4f91a3739&t=bfb6cede-7671-5504-0a11-79b13ef63703