Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Synapse] Initial Rest Client work for Synapse Access Control #18289

Merged
merged 8 commits into from
Nov 4, 2021
Merged

[Synapse] Initial Rest Client work for Synapse Access Control #18289

merged 8 commits into from
Nov 4, 2021

Conversation

joheredi
Copy link
Member

POC for a @azure-rest/synapse-access-control REST Client

@ghost ghost added the Synapse label Oct 20, 2021

See our [support policy](https://github.com/Azure/azure-sdk-for-js/blob/main/SUPPORT.md) for more details.

## Key concepts
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will this include a discussion of or links to more info about RLC?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, thanks for pointing this out. I didn't update the README, it will be similar to Purview's where we point users to the REST API docs and Info about the RLC

image

Copy link
Member

@deyaaeldeen deyaaeldeen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am not sure if you will update the readme in this PR based on @annelo-msft's comment but otherwise it looks good!

@joheredi
Copy link
Member Author

joheredi commented Nov 4, 2021

I am not sure if you will update the readme in this PR based on @annelo-msft's comment but otherwise it looks good!

Yup, I updated the README, it looks like this now. Referencing the RLC docs
image

@joheredi joheredi merged commit df05347 into Azure:main Nov 4, 2021
sadasant pushed a commit to sadasant/azure-sdk-for-js that referenced this pull request Nov 6, 2021
…18289)

* Initial Rest Client work for Synapse Access Control

* Update ci pipeline

* Update tests

* Update pagination helper and test

* Add samples

* Fix Access Control rest

* Update broken links

* Fix format in agrifood
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants