Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

2 remaining RPs support identity #16329

Merged
merged 2 commits into from
Jul 12, 2021
Merged

2 remaining RPs support identity #16329

merged 2 commits into from
Jul 12, 2021

Conversation

dw511214992
Copy link
Member

@dw511214992 dw511214992 commented Jul 9, 2021 •
edited
Loading

The root casue of #16299 is that some times subscriptioId is a parameter of method. The original script always filter the subscriptionId

@ghost ghost added App Configuration Azure.ApplicationModel.Configuration Service Bus KeyVault Storage Storage Service (Queues, Blobs, Files) Synapse Search Monitor Monitor, Monitor Ingestion, Monitor Query labels Jul 9, 2021
@dw511214992 dw511214992 changed the base branch from main to feature/v4 July 9, 2021 04:28
@dw511214992 dw511214992 removed App Configuration Azure.ApplicationModel.Configuration KeyVault Monitor Monitor, Monitor Ingestion, Monitor Query Search Service Bus Storage Storage Service (Queues, Blobs, Files) Synapse labels Jul 9, 2021
@dw511214992 dw511214992 force-pushed the dw/support-identity branch from 5a83d43 to c0a59c9 Compare July 9, 2021 08:20
@dw511214992 dw511214992 changed the title support identity script bugfix and 2RP support identity 2 remaining RPs support identity Jul 9, 2021
@dw511214992 dw511214992 merged commit 24c4d46 into feature/v4 Jul 12, 2021
@dw511214992 dw511214992 deleted the dw/support-identity branch July 12, 2021 00:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lirenhe lirenhe lirenhe left review comments

@deyaaeldeen deyaaeldeen deyaaeldeen approved these changes

@sarangan12 sarangan12 Awaiting requested review from sarangan12

@ramya-rao-a ramya-rao-a Awaiting requested review from ramya-rao-a

@qiaozha qiaozha Awaiting requested review from qiaozha qiaozha is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dw511214992 @deyaaeldeen @lirenhe