[EventHubs] Helper function to parse connection string #12684
Conversation
|
Thank you for your contribution maorleger! We will review the pull request and get back to you soon. |
25e4035 to
b14f329
Compare
|
/azp run js - eventhubs - tests |
|
No pipelines are associated with this pull request. |
|
/azp run js - eventhubs-client - tests |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run js - eventhubs-client - tests |
|
Commenter does not have sufficient privileges for PR 12684 in repo Azure/azure-sdk-for-js |
|
/azp run js - eventhubs-client - tests |
|
Azure Pipelines successfully started running 1 pipeline(s). |
We have #12397 that tracks the need to have a folder holding common code between EH & SB, but is not shipped as a public package. Something like how we did with keyvault-common. We can then move this common code out. |
|
This pull request is protected by Check Enforcer. What is Check Enforcer?Check Enforcer helps ensure all pull requests are covered by at least one check-run (typically an Azure Pipeline). When all check-runs associated with this pull request pass then Check Enforcer itself will pass. Why am I getting this message?You are getting this message because Check Enforcer did not detect any check-runs being associated with this pull request within five minutes. This may indicate that your pull request is not covered by any pipelines and so Check Enforcer is correctly blocking the pull request being merged. What should I do now?If the check-enforcer check-run is not passing and all other check-runs associated with this PR are passing (excluding license-cla) then you could try telling Check Enforcer to evaluate your pull request again. You can do this by adding a comment to this pull request as follows: What if I am onboarding a new service?Often, new services do not have validation pipelines associated with them, in order to bootstrap pipelines for a new service, you can issue the following command as a pull request comment: |
e63b6f4 to
e027090
Compare
e027090 to
c1d90f9
Compare
This commit adds the following to the Event Hubs package to satisfy the requirements listed in Azure#11894: - A helper methods `parseEventHubConnectionString` that validates and parses a given connection string - An interface `EventHubConnectionStringProperties` that defines the output of the above method.
Co-authored-by: Ramya Rao <ramya.rao.a@outlook.com>
c1d90f9 to
392192d
Compare
|
/azp run js - eventhubs-client - tests |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
Looks like this test has been failing since Sunday https://dev.azure.com/azure-sdk/internal/_build/results?buildId=699877&view=logs&j=38753cb9-b155-5978-2d3f-2d89d306e985&t=76836834-f1b7-5761-81f0-12284562de71 Took a look at it, ran it locally on my mac with the same node version and it passes in isolation so I suspect something must have changed during the private/public test split to cause some test pollution. Since it's unrelated to my changes I will make an issue to investigate this. |
|
/check-enforcer override |
What
Add the following to the Event Hubs package:
parseEventHubConnectionStringthat validates andparses a given connection string
EventHubConnectionStringPropertiesthat defines theoutput of the above method.
Why
In a recent PR the same change has been made for ServiceBus to provide a
parsing utility that can help transform a raw connection string for use
with credential-based client creation.
Callouts
whether I should leave it duplicated because of other work in that area or DRY up the code
(and if so, where would be a good place to move the shared logic to)
Implements #11894