Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Identity] Simplify the HTTP request mock for Node and the Browser #19420

Closed
sadasant opened this issue Dec 16, 2021 · 0 comments · Fixed by #19824
Closed

[Identity] Simplify the HTTP request mock for Node and the Browser #19420

sadasant opened this issue Dec 16, 2021 · 0 comments · Fixed by #19824
Assignees
@sadasant
Labels
Azure.Identity
Milestone
[2022] February

Comments

@sadasant
Copy link
Contributor

The HTTP request mock for Node and the Browser are overly complicated. It should be possible to simplify them into something much simpler. Perhaps a mock to the core-rest-pipeline classes instead of mocking http and https’s request?

(From: #17489 (comment))
@sadasant sadasant added this to the [2022] February milestone Dec 16, 2021
@sadasant sadasant self-assigned this Dec 16, 2021
@sadasant sadasant mentioned this issue Dec 16, 2021
Closed
6 tasks
@sadasant sadasant mentioned this issue Jan 13, 2022
Merged
1 task
@sadasant sadasant changed the title [Identity] Simplify the HTTP request mock for Node and the Browser. [Identity] Simplify the HTTP request mock for Node and the Browser Jan 13, 2022
sadasant added a commit that referenced this issue Jan 14, 2022
@sadasant
[Identity] Refactoring the HTTP request mocking to be easier to under…
dd5b1f6 
…stand in context (#19824)

Updated the test HTTP mocks to use classes instead of closure. Fixed #19420
azure-sdk pushed a commit to azure-sdk/azure-sdk-for-js that referenced this issue Jun 13, 2022
CodeGen from PR 19420 in Azure/azure-rest-api-specs
6f34ac9 
Update readme.md (Azure#19420)
@github-actions github-actions bot locked and limited conversation to collaborators Apr 11, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@sadasant sadasant

Labels
Azure.Identity
Projects
None yet
Milestone
[2022] February
1 participant
@sadasant