Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[core-rest-pipeline] Challenge API alignment #14787

Closed
sadasant opened this issue Apr 7, 2021 · 3 comments
Closed

[core-rest-pipeline] Challenge API alignment #14787

sadasant opened this issue Apr 7, 2021 · 3 comments
Assignees
@jeremymeng
Labels
Azure.Identity blocking-release Blocks release
Milestone
[2021] May

Comments

@sadasant
Copy link
Contributor

sadasant commented Apr 7, 2021 •
edited
Loading

  • Change "authenticate" for "authorize" in the challenge callbacks.
  • Do not pass challenge: string on authenticateRequestOnChallenge, pass the whole response through ChallengeCallbackOptions.'
  • Do not expose the default callbacks on the public API.
@sadasant sadasant added this to the [2021] May milestone Apr 7, 2021
@jeremymeng
Copy link
Member

Address in late commits of #13888

@sadasant
Copy link
Contributor Author

sadasant commented Apr 8, 2021

@jeremymeng thank you!

@sadasant sadasant mentioned this issue Apr 12, 2021
Merged
@ramya-rao-a ramya-rao-a mentioned this issue Apr 13, 2021
Closed
@ramya-rao-a
Copy link
Contributor

Moving this feedback to the issue tracking the Continous Access Evaluation feature i.e. #13156

openapi-sdkautomation bot pushed a commit to AzureSDKAutomation/azure-sdk-for-js that referenced this issue Jul 14, 2021
CodeGen from PR 14787 in Azure/azure-rest-api-specs
c1697e7 
Azure Health Bot MSI support (Azure#14787)

* Azure Health Bot - copy the existing version into new directory structure.

* Azure Health Bot - Updates for new API, including:
1. Azure Health Bot MSI support in API 2021-06-10.
2. Examples fixes.
3. Azure Health Bot naming (not Microsoft Healthcare Bot).
@github-actions github-actions bot locked and limited conversation to collaborators Apr 12, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@jeremymeng jeremymeng

Labels
Azure.Identity blocking-release Blocks release
Projects
None yet
Milestone
[2021] May
Development

No branches or pull requests
3 participants
@sadasant @jeremymeng @ramya-rao-a