servicefabric-track2 (#18504)

* servicefabric-track2

* update

eng/ignore-links.txt

@@ -16,3 +16,5 @@ https://docs.microsoft.com/javascript/api/@azure/arm-extendedlocation
 https://github.com/Azure/azure-sdk-for-js/tree/main/sdk/quota/arm-extendedlocation
 https://docs.microsoft.com/javascript/api/@azure/arm-videoanalyzer
 https://github.com/Azure/azure-sdk-for-js/tree/main/sdk/videoanalyzer/arm-videoanalyzer
+https://docs.microsoft.com/javascript/api/@azure/arm-servicefabric
+https://github.com/Azure/azure-sdk-for-js/tree/main/sdk/servicefabric/arm-servicefabric

rush.json

@@ -1045,6 +1045,11 @@
       "packageName": "@azure/arm-streamanalytics",
       "projectFolder": "sdk/streamanalytics/arm-streamanalytics",
       "versionPolicyName": "management"
+    },
+    {
+      "packageName": "@azure/arm-servicefabric",
+      "projectFolder": "sdk/servicefabric/arm-servicefabric",
+      "versionPolicyName": "management"
     }
   ]
 }

sdk/servicefabric/arm-servicefabric/CHANGELOG.md

@@ -0,0 +1,14 @@
+## 2.0.0-beta.1 (2021-11-03)
+
+This is the first preview for the new version of the `@azure/arm-servicefabric` package that follows the new [guidelines for TypeScript SDKs](https://azure.github.io/azure-sdk/typescript_introduction.html) for Azure services.
+
+While this package remains auto generated, the SDK generator itself has undergone changes to comply with the above guidelines in order to generate packages that are idiomatic to the JavaScript/TypeScript ecosystem and consistent with other packages for Azure services. For more on this, please see [State of the Azure SDK 2021](https://devblogs.microsoft.com/azure-sdk/state-of-the-azure-sdk-2021/).
+
+Please note that this version has breaking changes, all of which were made after careful consideration during the authoring of the guidelines and user studies.
+
+**Noteworthy changes and features**
+- Authentication: The packages `@azure/ms-rest-nodeauth` or `@azure/ms-rest-browserauth` are no longer supported. Use package [@azure/identity](https://www.npmjs.com/package/@azure/identity) instead. Select a credential from Azure Identity examples based on the authentication method of your choice.
+- Callbacks: Method overloads that used callbacks have been removed and the use of promises is encouraged instead.
+- List operations now return an iterable result that follows the `PagedAsyncIterableIterator` interface as opposed to the previous model where you had to make a new request using the link to the next page.
+- Long running operations i.e. the Lro related object returned by methods whose names started with `begin`, now uses `pollUntilDone` to check whether the request is finished, instead of `pollUntilFinished`. To get the final result, use the corresponding method that will have the suffix `AndWait`.
+- The SDK only supports ECMAScript 2015 (ES6) and beyond, all projects that referenced this SDK should be upgraded to use ES6.

sdk/servicefabric/arm-servicefabric/LICENSE.txt → sdk/servicefabric/arm-servicefabric/LICENSE

@@ -1,6 +1,6 @@
 The MIT License (MIT)
 
-Copyright (c) 2020 Microsoft
+Copyright (c) 2021 Microsoft
 
 Permission is hereby granted, free of charge, to any person obtaining a copy
 of this software and associated documentation files (the "Software"), to deal
@@ -18,4 +18,4 @@ FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE
 AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
 LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM,
 OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE
-SOFTWARE.
+SOFTWARE.

sdk/servicefabric/arm-servicefabric/README.md

@@ -1,103 +1,94 @@
-## Azure ServiceFabricManagementClient SDK for JavaScript
+# Azure ServiceFabricManagement client library for JavaScript
 
-This package contains an isomorphic SDK for ServiceFabricManagementClient.
+This package contains an isomorphic SDK (runs both in Node.js and in browsers) for Azure ServiceFabricManagement client.
+
+Service Fabric Management Client
+
+[Source code](https://github.com/Azure/azure-sdk-for-js/tree/main/sdk/servicefabric/arm-servicefabric) |
+[Package (NPM)](https://www.npmjs.com/package/@azure/arm-servicefabric) |
+[API reference documentation](https://docs.microsoft.com/javascript/api/@azure/arm-servicefabric) |
+[Samples](https://github.com/Azure-Samples/azure-samples-js-management)
+
+## Getting started
 
 ### Currently supported environments
 
 - [LTS versions of Node.js](https://nodejs.org/about/releases/)
-- Latest versions of Safari, Chrome, Edge, and Firefox.
+- Latest versions of Safari, Chrome, Edge and Firefox.
+
+### Prerequisites
+
+- An [Azure subscription][azure_sub].
 
-### How to Install
+### Install the `@azure/arm-servicefabric` package
+
+Install the Azure ServiceFabricManagement client library for JavaScript with `npm`:
 
 ```bash
 npm install @azure/arm-servicefabric
 ```
 
-### How to use
+### Create and authenticate a `ServiceFabricManagementClient`
+
+To create a client object to access the Azure ServiceFabricManagement API, you will need the `endpoint` of your Azure ServiceFabricManagement resource and a `credential`. The Azure ServiceFabricManagement client can use Azure Active Directory credentials to authenticate.
+You can find the endpoint for your Azure ServiceFabricManagement resource in the [Azure Portal][azure_portal].
 
-#### nodejs - Authentication, client creation and get clusters as an example written in TypeScript.
+You can authenticate with Azure Active Directory using a credential from the [@azure/identity][azure_identity] library or [an existing AAD Token](https://github.com/Azure/azure-sdk-for-js/blob/master/sdk/identity/identity/samples/AzureIdentityExamples.md#authenticating-with-a-pre-fetched-access-token).
 
-##### Install @azure/ms-rest-nodeauth
+To use the [DefaultAzureCredential][defaultazurecredential] provider shown below, or other credential providers provided with the Azure SDK, please install the `@azure/identity` package:
 
-- Please install minimum version of `"@azure/ms-rest-nodeauth": "^3.0.0"`.
 ```bash
-npm install @azure/ms-rest-nodeauth@"^3.0.0"
+npm install @azure/identity
 ```
 
-##### Sample code
-
-```typescript
-import * as msRest from "@azure/ms-rest-js";
-import * as msRestAzure from "@azure/ms-rest-azure-js";
-import * as msRestNodeAuth from "@azure/ms-rest-nodeauth";
-import { ServiceFabricManagementClient, ServiceFabricManagementModels, ServiceFabricManagementMappers } from "@azure/arm-servicefabric";
-const subscriptionId = process.env["AZURE_SUBSCRIPTION_ID"];
-
-msRestNodeAuth.interactiveLogin().then((creds) => {
-  const client = new ServiceFabricManagementClient(creds, subscriptionId);
-  const resourceGroupName = "testresourceGroupName";
-  const clusterName = "testclusterName";
-  client.clusters.get(resourceGroupName, clusterName).then((result) => {
-    console.log("The result is:");
-    console.log(result);
-  });
-}).catch((err) => {
-  console.error(err);
-});
+You will also need to **register a new AAD application and grant access to Azure ServiceFabricManagement** by assigning the suitable role to your service principal (note: roles such as `"Owner"` will not grant the necessary permissions).
+Set the values of the client ID, tenant ID, and client secret of the AAD application as environment variables: `AZURE_CLIENT_ID`, `AZURE_TENANT_ID`, `AZURE_CLIENT_SECRET`.
+
+For more information about how to create an Azure AD Application check out [this guide](https://docs.microsoft.com/azure/active-directory/develop/howto-create-service-principal-portal).
+
+```javascript
+const { ServiceFabricManagementClient } = require("@azure/arm-servicefabric");
+const { DefaultAzureCredential } = require("@azure/identity");
+const subscriptionId = "00000000-0000-0000-0000-000000000000";
+const client = new ServiceFabricManagementClient(new DefaultAzureCredential(), subscriptionId);
 ```
 
-#### browser - Authentication, client creation and get clusters as an example written in JavaScript.
+## Key concepts
 
-##### Install @azure/ms-rest-browserauth
+### ServiceFabricManagementClient
 
-```bash
-npm install @azure/ms-rest-browserauth
-```
+`ServiceFabricManagementClient` is the primary interface for developers using the Azure ServiceFabricManagement client library. Explore the methods on this client object to understand the different features of the Azure ServiceFabricManagement service that you can access.
+
+## Troubleshooting
+
+### Logging
 
-##### Sample code
-
-See https://github.com/Azure/ms-rest-browserauth to learn how to authenticate to Azure in the browser.
-
-- index.html
-```html
-<!DOCTYPE html>
-<html lang="en">
-  <head>
-    <title>@azure/arm-servicefabric sample</title>
-    <script src="node_modules/@azure/ms-rest-js/dist/msRest.browser.js"></script>
-    <script src="node_modules/@azure/ms-rest-azure-js/dist/msRestAzure.js"></script>
-    <script src="node_modules/@azure/ms-rest-browserauth/dist/msAuth.js"></script>
-    <script src="node_modules/@azure/arm-servicefabric/dist/arm-servicefabric.js"></script>
-    <script type="text/javascript">
-      const subscriptionId = "<Subscription_Id>";
-      const authManager = new msAuth.AuthManager({
-        clientId: "<client id for your Azure AD app>",
-        tenant: "<optional tenant for your organization>"
-      });
-      authManager.finalizeLogin().then((res) => {
-        if (!res.isLoggedIn) {
-          // may cause redirects
-          authManager.login();
-        }
-        const client = new Azure.ArmServicefabric.ServiceFabricManagementClient(res.creds, subscriptionId);
-        const resourceGroupName = "testresourceGroupName";
-        const clusterName = "testclusterName";
-        client.clusters.get(resourceGroupName, clusterName).then((result) => {
-          console.log("The result is:");
-          console.log(result);
-        }).catch((err) => {
-          console.log("An error occurred:");
-          console.error(err);
-        });
-      });
-    </script>
-  </head>
-  <body></body>
-</html>
+Enabling logging may help uncover useful information about failures. In order to see a log of HTTP requests and responses, set the `AZURE_LOG_LEVEL` environment variable to `info`. Alternatively, logging can be enabled at runtime by calling `setLogLevel` in the `@azure/logger`:
+
+```javascript
+const { setLogLevel } = require("@azure/logger");
+setLogLevel("info");
 ```
 
+For more detailed instructions on how to enable logs, you can look at the [@azure/logger package docs](https://github.com/Azure/azure-sdk-for-js/tree/main/sdk/core/logger).
+
+## Next steps
+
+Please take a look at the [samples](https://github.com/Azure-Samples/azure-samples-js-management) directory for detailed examples on how to use this library.
+
+## Contributing
+
+If you'd like to contribute to this library, please read the [contributing guide](https://github.com/Azure/azure-sdk-for-js/blob/main/CONTRIBUTING.md) to learn more about how to build and test the code.
+
 ## Related projects
 
-- [Microsoft Azure SDK for Javascript](https://github.com/Azure/azure-sdk-for-js)
+- [Microsoft Azure SDK for JavaScript](https://github.com/Azure/azure-sdk-for-js)
+
+![Impressions](https://azure-sdk-impressions.azurewebsites.net/api/impressions/azure-sdk-for-js%2Fsdk%2Fservicefabric%2Farm-servicefabric%2FREADME.png)
 
-![Impressions](https://azure-sdk-impressions.azurewebsites.net/api/impressions/azure-sdk-for-js/sdk/servicefabric/arm-servicefabric/README.png)
+[azure_cli]: https://docs.microsoft.com/cli/azure
+[azure_sub]: https://azure.microsoft.com/free/
+[azure_sub]: https://azure.microsoft.com/free/
+[azure_portal]: https://portal.azure.com
+[azure_identity]: https://github.com/Azure/azure-sdk-for-js/tree/main/sdk/identity/identity
+[defaultazurecredential]: https://github.com/Azure/azure-sdk-for-js/tree/main/sdk/identity/identity#defaultazurecredential

sdk/servicefabric/arm-servicefabric/_meta.json

@@ -0,0 +1,7 @@
+{
+  "commit": "0fba9ba4b78d20fc1a7ec251dab889b7a7eb8afd",
+  "readme": "specification/servicefabric/resource-manager/readme.md",
+  "autorest_command": "autorest --version=3.1.3 --typescript --modelerfour.lenient-model-deduplication --head-as-boolean=true --license-header=MICROSOFT_MIT_NO_VERSION --generate-test --typescript-sdks-folder=D:\\mydev\\azure-sdk-for-js ../azure-rest-api-specs/specification/servicefabric/resource-manager/readme.md --use=@autorest/typescript@6.0.0-beta.14",
+  "repository_url": "https://github.com/Azure/azure-rest-api-specs.git",
+  "use": "@autorest/typescript@6.0.0-beta.14"
+}

sdk/servicefabric/arm-servicefabric/api-extractor.json

@@ -0,0 +1,18 @@
+{
+  "$schema": "https://developer.microsoft.com/json-schemas/api-extractor/v7/api-extractor.schema.json",
+  "mainEntryPointFilePath": "./dist-esm/src/index.d.ts",
+  "docModel": { "enabled": true },
+  "apiReport": { "enabled": true, "reportFolder": "./review" },
+  "dtsRollup": {
+    "enabled": true,
+    "untrimmedFilePath": "",
+    "publicTrimmedFilePath": "./types/arm-servicefabric.d.ts"
+  },
+  "messages": {
+    "tsdocMessageReporting": { "default": { "logLevel": "none" } },
+    "extractorMessageReporting": {
+      "ae-missing-release-tag": { "logLevel": "none" },
+      "ae-unresolved-link": { "logLevel": "none" }
+    }
+  }
+}