Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[TESTING ONLY, WILL NOT BE CHECKED IN] Change core file to ensure version test matrix #43986

Closed
wants to merge 4 commits into from
Closed

[TESTING ONLY, WILL NOT BE CHECKED IN] Change core file to ensure version test matrix #43986

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
b648c16
[TESTING ONLY, WILL NOT BE CHECKED IN] Change core file to ensure ver…
JimSuplizio Jan 30, 2025
5981d1e
Set EnablePRGeneration to true when generating job matrix for a PR
JimSuplizio Jan 30, 2025
b4573c5
Update PreGenerationSteps for PR matrix gen, remove language-settings…
JimSuplizio Jan 30, 2025
3a40394
Update sparse checkout paths for PR matrix gen
JimSuplizio Jan 30, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 15 additions & 0 deletions eng/pipelines/templates/jobs/ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -451,6 +451,21 @@ jobs:
- ${{ config }}
- ${{ each config in parameters.AdditionalMatrixConfigs }}:
- ${{ config }}
${{ if eq(parameters.ServiceDirectory, 'auto') }}:
EnablePRGeneration: true
SparseCheckoutPaths:
- '**/*.xml'
- '**/*.md'
- '**/ci*.yml' # necessary for save-package-properties.yml
PreGenerationSteps:
- task: UsePythonVersion@0
displayName: 'Use Python $(PythonVersion)'
inputs:
versionSpec: $(PythonVersion)
- template: /eng/common/pipelines/templates/steps/save-package-properties.yml
parameters:
ServiceDirectory: ${{parameters.ServiceDirectory}}
ExcludePaths: ${{parameters.ExcludePaths}}
MatrixFilters: ${{ parameters.MatrixFilters }}
MatrixReplace: ${{ parameters.MatrixReplace }}
CloudConfig:
Expand Down
20 changes: 11 additions & 9 deletions sdk/core/azure-core/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,8 @@

[![Build Documentation](https://img.shields.io/badge/documentation-published-blue.svg)](https://azure.github.io/azure-sdk-for-java)

JRS-CHANGE FOR TESTING PURPOSES AND WILL NOT BE CHECKED IN.

Azure Core provides shared primitives, abstractions, and helpers for modern Java Azure SDK client libraries.
These libraries follow
the [Azure SDK Design Guidelines for Java](https://azure.github.io/azure-sdk/java_introduction.html)
Expand Down Expand Up @@ -116,22 +118,22 @@ polling is cancelled or reaches a terminal state.

### Configuring Builders

Builders are used to create service clients and some `TokenCredential` implementations. They can be configured with a
variety of options, including `HttpPipeline` and `HttpClient` for HTTP-based clients and more general options such as
`Configuration` and`endpoint`. To allow for simpler integration into frameworks such as Spring and to allow generic
Builders are used to create service clients and some `TokenCredential` implementations. They can be configured with a
variety of options, including `HttpPipeline` and `HttpClient` for HTTP-based clients and more general options such as
`Configuration` and`endpoint`. To allow for simpler integration into frameworks such as Spring and to allow generic
methods to be used for all builders `azure-core` provides a set of interfaces that can be implemented to provide
the necessary functionality.

#### HttpTrait<T>

`HttpTrait<T>` contains methods for setting key configurations for HTTP-based clients. This interface will allow you to
configure the `HttpClient`, `HttpPipeline`, `HttpPipelinePolicy`s, `RetryOptions`, `HttpLogOptions`, and `ClientOptions`
configure the `HttpClient`, `HttpPipeline`, `HttpPipelinePolicy`s, `RetryOptions`, `HttpLogOptions`, and `ClientOptions`
(preferably `HttpClientOptions` as it is more specific for HTTP-based service clients).

For builders that expose `HttpTrait<T>`, if an `HttpPipeline` or `HttpClient` isn't set a default instance will be
created based on classpath configurations and the `ClientOptions` based to the builder. This can cause confusion if
you're expecting specific behavior for your client, such as using a proxy that wasn't loaded from the environment. To
avoid this, it is recommended to always set the `HttpPipeline` or `HttpClient` in all clients if you're building if your
For builders that expose `HttpTrait<T>`, if an `HttpPipeline` or `HttpClient` isn't set a default instance will be
created based on classpath configurations and the `ClientOptions` based to the builder. This can cause confusion if
you're expecting specific behavior for your client, such as using a proxy that wasn't loaded from the environment. To
avoid this, it is recommended to always set the `HttpPipeline` or `HttpClient` in all clients if you're building if your
configurations aren't based on the environment running the application.

#### Credential Traits
Expand Down Expand Up @@ -185,7 +187,7 @@ and generally should be retried by the `RetryPolicy`.
#### HttpPipeline Timeouts

HttpPipeline timeouts are the next level of timeout handling the Azure SDKs provide. These timeouts are configured using
an `HttpPipelinePolicy` and configuring a timeout using either `Mono.timeout` for asynchronous requests or an
an `HttpPipelinePolicy` and configuring a timeout using either `Mono.timeout` for asynchronous requests or an
`ExecutorService` with a timed `get(long, TimeUnit)` for synchronous requests.

Depending on the location within the `HttpPipeline`, these timeouts may be captured by the `RetryPolicy` and retried.
Expand Down