Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add metrics emitted from BulkExecutor responsible for dynamic batch size tuning. #43716

Merged
merged 10 commits into from
Jan 9, 2025
Merged

Add metrics emitted from BulkExecutor responsible for dynamic batch size tuning. #43716

merged 10 commits into from
Jan 9, 2025

Conversation

jeet1995
Copy link
Member

@jeet1995 jeet1995 commented Jan 7, 2025 •
edited
Loading

Description

Added additional metrics responsible for dynamically tuning the batch size tuning within BulkExecutor.

All SDK Contribution checklist:

  • The pull request does not introduce [breaking changes]
  • CHANGELOG is updated for new features, bug fixes or other significant changes.
  • I have read the contribution guidelines.

General Guidelines and Best Practices

  • Title of the pull request is clear and informative.
  • There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For more information on cleaning up the commits in your PR, see this page.

Testing Guidelines

  • Pull request includes test coverage for the included changes.

@github-actions github-actions bot added the Cosmos label Jan 7, 2025
@azure-sdk
Copy link
Collaborator

API change check

APIView has identified API level changes in this PR and created following API reviews.

com.azure:azure-cosmos

@jeet1995 jeet1995 changed the title [No Review]: Bulk executor client metrics Add metrics emitted from BulkExecutor responsible for dynamic batch size tuning. Jan 7, 2025
@jeet1995 jeet1995 marked this pull request as ready for review January 7, 2025 14:55
@jeet1995 jeet1995 requested review from kirankumarkolli and a team as code owners January 7, 2025 14:55
@jeet1995 jeet1995 requested a review from Copilot January 7, 2025 14:57
@jeet1995
Copy link
Member Author

jeet1995 commented Jan 7, 2025

/azp run java - cosmos - tests

@azure-pipelines Azure Pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

FabianMeiswinkel
FabianMeiswinkel approved these changes Jan 8, 2025
View reviewed changes
Copy link
Member

@FabianMeiswinkel FabianMeiswinkel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - Thanks. Only ask is to also update https://github.com/Azure/azure-sdk-for-java/blob/main/sdk/cosmos/azure-cosmos/docs/Metrics.md

@jeet1995 jeet1995 enabled auto-merge (squash) January 9, 2025 16:33
@jeet1995
Copy link
Member Author

jeet1995 commented Jan 9, 2025

/check-enforcer override

@jeet1995 jeet1995 merged commit 71f176d into Azure:main Jan 9, 2025
31 of 38 checks passed
@jeet1995
Copy link
Member Author

jeet1995 commented Jan 9, 2025 •
edited
Loading

CI is all green - https://dev.azure.com/azure-sdk/public/_build/results?buildId=4462227&view=logs&jobId=9f80b0d8-38c5-5616-1cb0-ad6bbd88708c but GitHub isn't syncing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FabianMeiswinkel FabianMeiswinkel FabianMeiswinkel approved these changes

@kirankumarkolli kirankumarkolli Awaiting requested review from kirankumarkolli kirankumarkolli is a code owner

Copilot code review Copilot Awaiting requested review from Copilot

Assignees
No one assigned
Labels
Cosmos
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jeet1995 @azure-sdk @FabianMeiswinkel