Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cloning Options and so they don't get modified when a new instance is created. #4309

Merged
merged 27 commits into from
Jul 10, 2019

Conversation

conniey
Copy link
Member

@conniey conniey commented Jul 8, 2019

  • Clone EventHubProducerOptions, Builder options, Retry, so if any modifications occur to them, it does not affect the new instance.
  • Fix spelling error in MessageConstants.ABSOLUTE_EXPRITY_TIME
  • Cloneable classes implement Cloneable and expose public Object clone() { }

Fixes #4136, #3714

@conniey conniey requested review from JonathanGiles and mssfang July 8, 2019 21:50
@conniey conniey self-assigned this Jul 8, 2019
@conniey conniey added Client This issue points to a problem in the data-plane of the library. Event Hubs labels Jul 8, 2019
@conniey conniey merged commit d11336b into Azure:master Jul 10, 2019
@conniey conniey deleted the clone-options branch July 10, 2019 01:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Client This issue points to a problem in the data-plane of the library. Event Hubs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Event Hubs] Clone retry policy and other builder parameters
4 participants