If body is empty then return publisher emitting response instead of propagating empty publisher #4203
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ropagating empty publisher
|
This issue caused blob getProperties to return null. |
JonathanGiles
approved these changes
Jul 1, 2019
srnagar
approved these changes
Jul 1, 2019
There was a problem hiding this comment.
Please create a PR against this branch as well - https://github.com/Azure/azure-sdk-for-java/tree/release-preview-2
g2vinay
approved these changes
Jul 1, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
HttpLoggingPolicy::process return empty publisher when body is empty, the contract of process method is to return response for the next one in the chain. This PR ensure HttpLoggingPolicy::process adhere to this.