Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update AI Face codegen and customization #41823

Merged
merged 2 commits into from
Sep 13, 2024

Conversation

Han-msft
Copy link
Member

Description

Please add an informative description that covers that changes made by the pull request and link all relevant issues.

If an SDK is being regenerated based on a new swagger spec, a link to the pull request containing these swagger spec changes has been included above.

All SDK Contribution checklist:

  • The pull request does not introduce [breaking changes]
  • CHANGELOG is updated for new features, bug fixes or other significant changes.
  • I have read the contribution guidelines.

General Guidelines and Best Practices

  • Title of the pull request is clear and informative.
  • There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For more information on cleaning up the commits in your PR, see this page.

Testing Guidelines

  • Pull request includes test coverage for the included changes.

@azure-sdk
Copy link
Collaborator

API change check

APIView has identified API level changes in this PR and created following API reviews.

com.azure:azure-ai-vision-face

@Han-msft Han-msft marked this pull request as ready for review September 12, 2024 05:32
@Han-msft Han-msft requested a review from leareai as a code owner September 12, 2024 05:32
Copy link
Member

@weidongxu-microsoft weidongxu-microsoft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR is mostly a regen from an updated client.tsp, and solve some breaks.

The Administration related classes is in not final state, we will not review this part of the code.

Consider adding a changelog with breaking changes and new features for the update.
You can choose to delay this after next PR.

@weidongxu-microsoft weidongxu-microsoft merged commit 2853849 into Azure:main Sep 13, 2024
23 checks passed
anuchandy pushed a commit to anuchandy/azure-sdk-for-java that referenced this pull request Sep 13, 2024
jairmyree pushed a commit to jairmyree/azure-sdk-for-java that referenced this pull request Sep 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants