You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since version 2.42.0 of azure-resourcemanager-cosmos the model POJP classes can't be serialized/derserialized with Jackson Object-Mapper anymore because they implement com.azure.json.JsonSerializable now - to allow to still use Jackson ObjectMapper directly a module com.azure.core.serializer.json.jackson.JacksonJsonProvider .getJsonSerializableDatabindModule() needs to be registered with the ObjectMapper.
This PR is adding this moduleto react to the breaking change in 2.42.0 of azure-resourcemanager-cosmos.
All SDK Contribution checklist:
The pull request does not introduce [breaking changes]
CHANGELOG is updated for new features, bug fixes or other significant changes. - internal only change -not released after picking up 2.42.0 yet - no need to capture in changelog
Title of the pull request is clear and informative.
There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For more information on cleaning up the commits in your PR, see this page.
I don't think we should be doing this.
After migration to azure-json, all Jackson annotations has been removed from class/fields. Hence, even with jackson appearing in module-info.java, serialization/deserialization could be problematic.
I don't think we should be doing this. After migration to azure-json, all Jackson annotations has been removed from class/fields. Hence, even with jackson appearing in module-info.java, serialization/deserialization could be problematic.
That is true - and changing module-info did not help. So, using a different approach - but IMO it was really a terrible idea to make this breaking change and then release it as a minor version upgrade. azure-resourcemanager-cosmos should never have been moved to azure-core-json until moving to 3.* major version.
CosmosMgmtThis issue is related to a management-plane library.
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Since version 2.42.0 of azure-resourcemanager-cosmos the model POJP classes can't be serialized/derserialized with Jackson Object-Mapper anymore because they implement
com.azure.json.JsonSerializablenow - to allow to still use Jackson ObjectMapper directly a modulecom.azure.core.serializer.json.jackson.JacksonJsonProvider .getJsonSerializableDatabindModule()needs to be registered with the ObjectMapper.This PR is adding this moduleto react to the breaking change in 2.42.0 of azure-resourcemanager-cosmos.
All SDK Contribution checklist:
General Guidelines and Best Practices
Testing Guidelines
/azp run java - cosmos - sparkpipeline