New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Stop partition recovery flow when a client instance is closed. #41486

Merged

jeet1995 merged 58 commits into Azure:main from jeet1995:CircuitBreakerTests

Aug 22, 2024

Member

jeet1995 commented Aug 9, 2024 •

edited

Loading

The PR introduces the following changes:

Stops the partition recovery background task specific to per-partition circuit breaker and disposes the scheduler associated with this background task. Without explicitly doing this, the direct buffer memory was getting exhausted. The direct buffer memory is required for channel-specific resources and an exhaustion of this memory materializes as channel acquisition timeouts leading to the overall data plane operation to timing out.
Introduces a way to run the multi-master / multi-write test job with circuit breaker turned on and turned off.

jeet1995 added 12 commits

August 5, 2024 10:08


          Push down collection and partition key range resolution.

32260b7


          Tweaking threshold behavior.

4e124f6


          Fixing tests.

8a5dd05


          Fixing tests.

0847f40


          Fixing tests.

e958966


          Fixing tests.

8512d86


          Perform collectionLink normalization.

6b518ae


          Fix CI pipeline.

dda284b


          Reacting to review comments.

4ad9cb7


          Updated CHANGELOG.md.

17c6fc3


          Merge branch 'main' of github.com:jeet1995/azure-sdk-for-java into Fi…

17421dd

…xRetryIssueWhenFaultInjectedIntoAllOperationTypes

# Conflicts:
#	sdk/cosmos/azure-cosmos/CHANGELOG.md


          Force circuit breaking to be enabled.

72f711c

github-actions bot added the Cosmos label

jeet1995 added 2 commits

August 9, 2024 14:02


          Merge branch 'main' of github.com:jeet1995/azure-sdk-for-java into Ci…

626e041

…rcuitBreakerTests


          Merge branch 'FixRetryIssueWhenFaultInjectedIntoAllOperationTypes' of…

3b20f4f

… github.com:jeet1995/azure-sdk-for-java into CircuitBreakerTests

Collaborator

azure-sdk commented Aug 9, 2024

API change check

API changes are not detected in this pull request.

jeet1995 added 10 commits

August 12, 2024 18:39


          Increase error thresholds.

12b8cb2


          Merge branch 'main' of github.com:jeet1995/azure-sdk-for-java into Ci…

f776194

…rcuitBreakerTests

# Conflicts:
#	sdk/cosmos/azure-cosmos/CHANGELOG.md


          Force circuit breaker for certain tests.

6da8d6f


          Scope live test matrix.

26b9e37


          Scope live test matrix.

9f29399


          Scope live test matrix.

90a2367


          Close globalPartitionEndpointManagerForCircuitBreaker.

c56db87


          Close globalPartitionEndpointManagerForCircuitBreaker.

ff83078


          Use non-static scheduler.


          Test multi-region + circuit-breaker job.

9dbd519

Member Author

jeet1995 commented Aug 14, 2024

/azp run java - cosmos - tests

azure-pipelines bot commented Aug 14, 2024

Azure Pipelines successfully started running 1 pipeline(s).


          Test multi-region + circuit-breaker job.

daee7ae

Member Author

jeet1995 commented Aug 15, 2024

/azp run java - cosmos - tests

Azure deleted a comment from azure-pipelines bot

Azure deleted a comment from azure-pipelines bot

Azure deleted a comment from azure-pipelines bot

Azure deleted a comment from azure-pipelines bot


          Merge branch 'Azure:main' into CircuitBreakerTests

dc003c6

Member Author

jeet1995 commented Aug 21, 2024

/azp run java - cosmos - tests

azure-pipelines bot commented Aug 21, 2024

Azure Pipelines failed to run 1 pipeline(s).

Azure deleted a comment from azure-pipelines bot

Azure deleted a comment from azure-pipelines bot

Azure deleted a comment from azure-pipelines bot


          Attempt at fixing live tests pipeline.

8cb5dbf

Member Author

jeet1995 commented Aug 21, 2024

/azp run java - cosmos - tests

azure-pipelines bot commented Aug 21, 2024

Azure Pipelines successfully started running 1 pipeline(s).


          Reacting to review comments.

93b4d47

Member Author

jeet1995 commented Aug 21, 2024

/azp run java - cosmos - tests

azure-pipelines bot commented Aug 21, 2024

Azure Pipelines successfully started running 1 pipeline(s).


          Reacting to review comments.

3735f9c

Member Author

jeet1995 commented Aug 21, 2024

/azp run java - cosmos - tests

azure-pipelines bot commented Aug 21, 2024

Azure Pipelines successfully started running 1 pipeline(s).


          Reacting to review comments.

036ebe6

Member Author

jeet1995 commented Aug 21, 2024

/azp run java - cosmos - tests

azure-pipelines bot commented Aug 21, 2024

Azure Pipelines successfully started running 1 pipeline(s).


          Revert some live test pipeline changes.

82fb59d

Member Author

jeet1995 commented Aug 21, 2024

/azp run java - cosmos - tests

azure-pipelines bot commented Aug 21, 2024

Azure Pipelines successfully started running 1 pipeline(s).

FabianMeiswinkel approved these changes

View reviewed changes

Member

FabianMeiswinkel left a comment

LGTM - Thanks!

jeet1995 added 2 commits

August 22, 2024 15:27


          Merge branch 'main' of github.com:jeet1995/azure-sdk-for-java into Ci…

11920d8

…rcuitBreakerTests


          Updated CHANGELOG.md.

Member Author

jeet1995 commented Aug 22, 2024

/check-enforcer override

jeet1995 merged commit a7cb0c5 into Azure:main

58 of 60 checks passed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels