Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Javadoc updates #4143

Merged
merged 3 commits into from
Jun 26, 2019
Merged

Javadoc updates #4143

merged 3 commits into from
Jun 26, 2019

Conversation

conniey
Copy link
Member

@conniey conniey commented Jun 26, 2019

  • Looked through the javadocs in their compiled form. Made some small changes.

@conniey conniey added Event Hubs Client This issue points to a problem in the data-plane of the library. labels Jun 26, 2019
@conniey conniey self-assigned this Jun 26, 2019
@conniey conniey merged commit 87521ee into Azure:master Jun 26, 2019
@conniey conniey deleted the javadoc-updates branch June 26, 2019 22:51
sima-zhu pushed a commit that referenced this pull request Jun 27, 2019
@conniey @sima-zhu
Javadoc updates (#4143)
fd31617 
* Update documentation for SendOptions

* Update docs in EventPosition and PartitionProperties.

* Add @see to documentation.
sima-zhu pushed a commit to sima-zhu/azure-sdk-for-java that referenced this pull request Jun 29, 2019
@conniey @sima-zhu
Javadoc updates (Azure#4143)
8f17c71 
* Update documentation for SendOptions

* Update docs in EventPosition and PartitionProperties.

* Add @see to documentation.
alzimmermsft added a commit that referenced this pull request Jul 8, 2019
@alzimmermsft
storage-proto-2 branch to master (#4310)
7ce57b7 
* Generate blob client

* Address Rick's feedback

* Address checkstyle and p2 spot bugs

* Add Context parameter

* Generate queue and file

* Use block comment on private fields

* Readme for storage queue (#3848)

* Readme for storage queue

* Fix the exposed secret. (#3887)

* no secret on readme

* Client placeholder (#3891)

Boilerplate code for Azure Storage Files clients.

* Empty model classes so the project compiles (#3895)

Adds empty model classes so the project compiles

* Azure Storage Common Credentials and Policies (#3909)

Adds common credentials and policies to Azure Storage client and changes AutoREST Impl files with handwritten overrides until AutoREST codegen is updated.

* Merge back Storage UX study changes (#3973)

* Refactored for Track 2 according to design

* Conversion of client classes to conform to new architecture

* Addressed Compile Errors

Converted most classes to use com.azure.core as well as Reactor.
Excluded classes include
 * All "Clients" (handled elsewhere)
 * RequestRetryFactory (scheduled work)
 * Logging Factory (nontrivial and not necessary for upcoming milestone)

* Refactored ServiceClient to BlobServiceClient

* Convert methods in async raw to return Mono

* Initial builder work

* Blob Client x4 Restructured

Client design pattern for upcoming tests applied to BlobClient.
 * ___Client wraps ___AsyncClient
 * ___AsyncClient wraps ___AsyncRawClient
 * ___RawClient wraps AsyncRawClient
Raw blob clients are package-protected. Non-Raw blob clients are public.
All blob client constructors are package-protected, awaiting a builder.
Work for the other 5 client types is upcoming.

* Add builders for generated clients

* Add builders

* Add builders for clients

* NOT COMPLETE - Added correct types to method signatures in 4 sub types of client classes

* Completed correct method return types for all 4 sub types of clients

* Finished builder pattern implementation.

* Fixed page blob client builders

* Compiles!

* Halfway commit

Addressed some issues where sync clients used async method parameters.

* BlobClient javadocs

* Append, block, page blob javadocs

* Container client javadocs

* BlobServiceClientBuilder and related javadocs

* Add blob api test

* Cleaned up a few things

* Support creating child clients

* Add block blob api test

* Add Alan's SharedKeyCredential

* Fixed most upload/download logic.

* more block blob API test

* Minor fix to async block blob upload

* Set several classes to package-private

Postponing judgement of several classes carried over from v11 library.

* Temporarlily included a test sample file.

Includes REST operations
 * create container
 * list blobs
 * put blob (block blob)
 * get blob

* Add more docs for builders

* Temporarlily included a test sample file.

Includes REST operations
 * create container
 * list blobs
 * put blob (block blob)
 * get blob

* Minor fix

* Blob unit tests compile

* Minor fix

* Fix some compile issues in block blob tests

* Fixed signatures for listing containers.

Updated temporary sample file to show usage.

* Removed key

* Block blob tests pass

* Convert champion and hi pri tests.

* Most tests passing, commented out tests that cannot pass

* Added naive approaches to upload/download from file methods

* Fix connection string

* clean up imports

* Delete duplicate shared key credential

* More clean up

* Return types never return protocol-layer classes

They may return auto-gen models, but won't return ___Response or
___Headers.

* Add line breaks to class level docs

* Missing import

* Make builder constructor public

* Regenerate blob with fixed AutoRest

* Rename blob service client builder method

* Add more javadocs on builder

* Add more javadocs

* Add more info for list

* Minor changes

* Make BlobRange immutable and getContainerClient

* Clean up storage client docs

* More docs and changes from UX studies

* Fix typo

* Fix build break after merge

* Add toUrl() and get{Parent}Client()

* Return Response<T>

* Add Append/Block/Page blob items

* Add .exists() on container and blob client

* Support parallel download and upload

* Support listBlobsHierarchy()

* Upload is stable

* Clean up

* javadoc fixes for listBlobsHierarchy

* Supports AAD through azure-identity credentials

* Cleaned up BlobAPITests

* Cleaned up BlockBlobAPITests

* Download is also stable

* Cleaned up ContainerAPITests

* Fixing up APISpec

* Remove comments

* Fixes SharedKeyCredential

* Add .containerName() and .blobName() on builders

* Update more dependencies (#4020)

Updated bouncy castle and jackson dependencies in a couple more projects

* Kv secrets samples and readme (#3892)

KV Secrets Samples + Readme

* Keys Samples (#4022)

KV Keys Samples + Readme

*  removing spotbug issues (#4033)

* Batch REST API Update - June 2019 (#3861)

* Update Batch Java SDK

* Update  readmes

* Rebase into sdk folder

* Move recordings

* fix bad test

* Azure core fix for storage playback tests. (#4035)

* Make changes to not override the header content length

* Track 2: Event Hubs Client Library (#3655)

* Adding azure-messaging-eventhubs and azure-core-amqp pom.xml.

* Adding EventHubClient, EventHubClientBuilder, EventHubConsumer, EventHubConsumerOptions, EventHubProducer, 
and EventHubProducerOptions.

* Adding configuration options for EventHubClientBuilder.

* Adding azure-core-amqp with common classes to AMQP for Exceptions, Sessions, Links, Connections, TransportTypes, etc.

* Adding authorization with CBS node and getting Event Hub metadata.

* Adding functionality for EventHubConsumer and EventHubProducer.

* Adding support for Azure Identity and TokenCredential.

* Adding a bare set of tests for Azure Event Hubs client library.

* Helper constructor for storage conversion. (#4049)

* Fixing some unit tests

* Reverted change

* Builder fixes

* Add SAS Token Creds to Blobs

* Fix some tests

* Initial BlobInputStream & BlobOutputStream support

* Added snapshot to clients, added createContainer to StorageClient, credentials -> credential

* Address Jonathan's feedback

* Addresses Rick and Alan's comments

* Fix compilations

* Renaming fluent methods and removed context from public API

* Cleaning up changes

* Clean up blob input output stream

* Add entry points to input/output streams

* Moved model classes into model package

* Removed unused classes and classes that replicate core functionality

* Migrated and clean append and page blob unit tests

* Fix block with timeout

* Fix APISpec client credential

* Use async for blob output stream

* Cleaning up more unit tests

* Add retry policy and stablize input/output stream

* More testing

* Merge credentials on builders

* Change inputstream to use bytebuffer

* Cleaning up tests and trying to resolve page upload issues

* Fixed upload tests

* Pass snapshot param to generated methods

* Return url with snapshot on getBlobUrl()

* Return void on stageBlock and stageBlockFromUrl

* Address James's code review feedback

* Fix blob inputstream buffer leak

* Address Rick's code review feedback

* Add retry options on client builders

* Added unit test for snapshot download, fixed missing snapshot passing, eagerly set non-null path pieces

* Reverted pom file changes and commented out test

* Turning on another test

* resolve conflicts

* Fix OffsetDateTime parsing in IdentityClient (#4031)

* Event Hubs: Build break fix, multiple connection and CBS nodes, hanging sends fix (#4052)

* Reduce verbosity of LinkHandler logging.

* Put unconfirmedSends into map before dispatcher.invoke()

* Caching CBSChannelMono so that it is not received multiple times.

* Only sending work when the SenderLink has successfully opened.

* Closing ReactorReceiver message sink upon completion.

* Remove usage of AtomicReferenceFieldUpdator in ReactorConnection.

* Documentation changes in EventHubProducer.

* Fixing issue where EventHubConsumer is not properly subscribing for
events. Adding timeout.

* Rewrapping text and adding logging.

* Adding try/catch when unable to reschedule scheduler task.

* Do not reschedule authorization task if cancelled.

* Increasing wait time between retry.

* Event Hubs Samples (#4053)

* Add hello world sample.

* Adding ReceiveEvent sample.

* Adding samples to the correct aggregate report.

* Adding sample for getting Event Hub metadata

* Fixing bug where the lastRefreshInterval was not properly set. (#4069)

* Fixing bug where the lastRefreshInterval was not properly set.

* generated v2018_03_01 of redis (#4073)

* Cost Management: generated v2018_05_31 (#4076)

* generated v2018_05_31 of costmanagement

* Update parent version in pom

* Identity Library Updates (#4061)

Identity Library updates

* generated v2018_06_30 of automation (#3888)

* Add ci.yml for eventgrid. (#4085)

No need to wait for PR validation for this one.

* MySql: generated v2017_12_01_preview (#4082)

* generated v2017_12_01_preview of mysql

* updated azure-arm-parent version

* PostgreSql: generated v2017_12_01_preview (#4084)

* generated v2017_12_01_preview of postgresql

* updated azure-arm-parent version to 1.1.0

* Fix javadoc description and package groups (#4074)

* Fix javadoc description and package groups

* Include unit test coverage for identity

* re-order javadoc package groups

* generated v2018_04_01 and v2012_12_01_preview of IoTHub (#4088)

* Prep for move of keyvault track 1 libs. (#4093)

* Adding Event Hubs integration and Unit Tests (#4089)

* Adding integration tests for EventHubClient, Producer, Consumer, EventPosition, EventDataBatch, etc.

* Fixing bugs for ConnectionStringProperties and ReactorExecutor

* Adding other status (#4091)

Adding option to provide custom status  Issue #3930

* Publish code coverage results for track 2 build pipelines only (#4096)

* Eventhubs: generated v2017_04_01, v2015_08_01, and v2018_01_01_preview (#4090)

* generated v2017_04_01 of eventhubs

* generated v2018_01_01_preview of eventhubs

* generated v2015_08_01 of eventhubs

* Update client runtime v1 version to 1.6.10 (#4072)

* generated v2018_07_01_preview policyinsights (#3374)

* generated v2016_11_01 of storageimportexport (#4092)

* generated v2016_06_01 of recoveryservices, fixed build error (#3315)

* generated v2019_05_01 of machinelearningservices (#4101)

* Netapp 2019-05-01 and 2017-08-15 (#3508)

* generated netapp v2019-05-01

* adding v2017_08_15 version of netapp as not in sdk but published on maven

* Adds appinsights ci setup in advance of refactoring. (#3925)

* Setup cognitive services CI. (#4106)

* updated azure-arm-parent versioning

* generated v2018_07_01_preview of logic (#4112)

* Adding CONTRIBUTING.md and update version number (#4113)

* Adding CONTRIBUTING.md

* Updating version number to: 5.0.0-preview.1

* Adding more contents to contributing.

* Add link to log levels

* generated v2018_08_01 of network (#4120)

* updated pom versioning (#4121)

* generated v2015_03_20 of loganalytics (#4122)

* generated v2015_11_01_preview of operationsmanagement (#4123)

* updated azure-arm-parent versioning (#4124)

* Add Javadocs and code snippets (#4119)

* Adding Javadocs for EventData

* Adding javadocs for EventHubClientBuilder

* Adding more documentation for EventhubClient and EventHubConsumer

* Adding more documentation and snippets.

* EventHubConsumer: Adding documentation and snippets.

* Remove side-effect of setting proxy-configuration.

* Rename build -> buildAsyncClient

* Keyvault Updates (#4062)

Keyvault Config + Logging + Iterable + Tests Updates + Samples updates + README Updates

* Resourcehealth (#4142)

* added resourcehealth reference to api-specs

* generated v2015_01_01 of resourcehealth

* generated v2017_07_01 of resourcehealth

* Javadoc updates (#4143)

* Update documentation for SendOptions

* Update docs in EventPosition and PartitionProperties.

* Add @see to documentation.

* Added CI configuration files. (#4150)

This should have impact so bypassing checks.

* Cleanup Azure Core Fluent Method Names (#4149)

* Removing with from fluent method nanes

* Cleaning up the unit tests

* Clean up references in SDKs

* More tests and limiting the delivery credits from 8000 to 100. (#4135)

* Fixing minimum/maximum request sizes.

* Adding TestUtils class to unify a lot of duplicated logic when creating/comparing events.

* Adding EventHubConsumerTest.

* [maven-release-plugin] prepare release v1.0.0-preview.1

* [maven-release-plugin] prepare for next development iteration

* Add more SCM info

* README and samples (#4114)

* Add README
* Update Key concepts, Troubleshooting, Next steps
* Add samples

* Revert merge credentials

* Add snapshot on append blobs

* Fix build breaks after merge

* Overlooked merge conflict in spotbugs

* Turned on ServiceAPITests, migrated full ContainerAPITests, changed response type on container getPolicies

* Finished last migration of container client tests, removed 304 as a valid response

* Working on tests

* Removing context tests, added more comments to commented out tests

* Uncommenting tests

* Turning off linting for another pom to has PR validation pass

* Turn off linting to pass PR validation

* TODOs for commented out tests

* yml config

* pom update

* Fixed tests with wrong endpoint (#4222)

* Cherry picking commits from release-preview-2 branch and updating parent ref in storage pom (#4260)

* Update preview version (#4209)

* Update preview version for core and bump parent version

* Update parent pom version

* Update parent version for sdk template

* Use plugin to update version

* Add version to azure-core

* If body is empty then return publisher emitting response instead of propagating empty publisher (#4208)

* Update version of appconfig to 1.0.0-preview.1 (#4237)

* Update version of appconfig to 1.0.0-preview.1

* Update report versions for app configuration.

* Update EventHub core dependency version to preview 2 (#4221)

* Updating storage parent pom to use azure-client-sdk-parent 1.1.0

* The orginal storage-proto (source of storage-proto-2) had a bad merge with upstream master, fixing it (#4251)

* Adding test for BlobInputStream & BloboutputStream and simple blob listing (#4207)

* Adding test for BlobInputStream & BloboutputStream and simple blob listing

* Addressing review comment: use maxResult to test auto-pagination

* disabling failing tests due to not encoding blob-name

* Copying storage team's (James) fix to green more test, commenting out check for etag quote removal

* Fixing eTag quote escaping bug in storage

* Adding CustomHierarchicalListingDeserializer needed for deserialize blob hierarchy listing result

* Adding a test for explicit root container in endpoint

* Restructuring storage module (#4272)

* Restructring storage module to multiple modules

* including blobDownload fix from @sima-zhu

* Using sdk parent as the parent for storage blob

* Removed KeyVault POM file changes

* Removed unused package-info file
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JonathanGiles JonathanGiles JonathanGiles approved these changes

@jsquire jsquire Awaiting requested review from jsquire

@ramya-rao-a ramya-rao-a Awaiting requested review from ramya-rao-a

@mssfang mssfang Awaiting requested review from mssfang

Assignees

@conniey conniey

Labels
Client This issue points to a problem in the data-plane of the library. Event Hubs
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@conniey @JonathanGiles