-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Batch: Data plane TypeSpec #37319
Batch: Data plane TypeSpec #37319
Conversation
sdk/batch/azure-compute-batch/src/main/java/com/azure/compute/batch/BatchAsyncClient.java
Outdated
Show resolved
Hide resolved
sdk/batch/azure-compute-batch/src/main/java/com/azure/compute/batch/BatchAsyncClient.java
Outdated
Show resolved
Hide resolved
sdk/batch/azure-compute-batch/src/main/java/com/azure/compute/batch/BatchAsyncClient.java
Outdated
Show resolved
Hide resolved
...ch/azure-compute-batch/src/test/java/com/azure/compute/batch/BatchServiceClientTestBase.java
Outdated
Show resolved
Hide resolved
sdk/batch/azure-compute-batch/src/test/java/com/azure/compute/batch/FileTests.java
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
(See the other comments)
sdk/batch/azure-compute-batch/src/main/java/com/azure/compute/batch/models/OptionsBag.java
Outdated
Show resolved
Hide resolved
sdk/batch/azure-compute-batch/src/main/java/com/azure/compute/batch/BatchAsyncClient.java
Outdated
Show resolved
Hide resolved
sdk/batch/azure-compute-batch/src/main/java/com/azure/compute/batch/BatchAsyncClient.java
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nit: Can we rename BatchServiceClientTestBase to BatchClientTestBase?
sdk/batch/azure-compute-batch/src/main/java/com/azure/compute/batch/models/OptionsBag.java
Outdated
Show resolved
Hide resolved
...zure-compute-batch/src/main/java/com/azure/compute/batch/models/ReimageBatchNodeOptions.java
Outdated
Show resolved
Hide resolved
sdk/batch/azure-compute-batch/src/test/java/com/azure/compute/batch/JobScheduleTests.java
Outdated
Show resolved
Hide resolved
.../azure-compute-batch/src/main/java/com/azure/compute/batch/models/ListBatchNodesOptions.java
Outdated
Show resolved
Hide resolved
...e-compute-batch/src/main/java/com/azure/compute/batch/models/BatchClientParallelOptions.java
Outdated
Show resolved
Hide resolved
...pute-batch/src/main/java/com/azure/compute/batch/models/GetBatchNodeRemoteLoginSettings.java
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good - just a couple of very minor comments.
...ure-compute-batch/src/main/java/com/azure/compute/batch/implementation/task/TaskManager.java
Show resolved
Hide resolved
...e-compute-batch/src/main/java/com/azure/compute/batch/implementation/task/TaskSubmitter.java
Outdated
Show resolved
Hide resolved
89a6ad4
to
78cd626
Compare
1d6f6ff
to
596c2ed
Compare
Remove ocp date header, add options bag support, add createTasks method, and fix minor typos
Description
Major fixes:
Ocp Date Header
Options Bag:
Internal
in its name in a handwritten method without theInternal
tag (for example,enableJobInternal
is wrapped byenableJob
). Did this for methods with and without options bags (for example,enableJob(String jobId)
andenableJob(String jobId, EnableBatchJobOptions options)
)InternalWithResponse
(e.g.getApplicationInternalWithResponse
), add a handwritten method without the Internal tag that takes in the same parameters and returns that internal method (e.g.getApplicationWithResponse
returnsthis.getApplicationInternalWithResponse
)createTasks Async method:
createTasks
method to the BatchAsyncClientcreateTasks
logic for the sync and async clients into custom classes in task directoryTests:
createTasks
methodMinor fixes:
For more context on the options bag change, see: https://apiview.dev/Assemblies/Conversation/39c0b0984fcc45ebae23d581e3afc9ed
Please add an informative description that covers that changes made by the pull request and link all relevant issues.
If an SDK is being regenerated based on a new swagger spec, a link to the pull request containing these swagger spec changes has been included above.
All SDK Contribution checklist:
General Guidelines and Best Practices
Testing Guidelines