App Config Spring - Arch Review Comments #34022

mrm9084 · 2023-03-15T00:00:13Z

Description

Updates from the Arch Review + bug fixes.

All SDK Contribution checklist:

The pull request does not introduce [breaking changes]
CHANGELOG is updated for new features, bug fixes or other significant changes.
I have read the contribution guidelines.

General Guidelines and Best Practices

Title of the pull request is clear and informative.
There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For more information on cleaning up the commits in your PR, see this page.

Testing Guidelines

Pull request includes test coverage for the included changes.

…re. Fixed bug were invalid feature flags would cause refresh loop.

…/java/com/azure/spring/cloud/config/implementation/http/policy/TracingInfo.java Co-authored-by: Xiaolu Dai <31124698+saragluna@users.noreply.github.com>

…/java/com/azure/spring/cloud/config/implementation/AppConfigurationReplicaClient.java Co-authored-by: Xiaolu Dai <31124698+saragluna@users.noreply.github.com>

…-java into ArchReviewComments

chenrujun

Please fix the pipeline failure.

.../azure/spring/cloud/appconfiguration/config/web/implementation/AppConfigurationEndpoint.java

...m/azure/spring/cloud/appconfiguration/config/implementation/AppConfigurationRefreshUtil.java

...ring/cloud/appconfiguration/config/implementation/AppConfigurationReplicaClientsBuilder.java

...agement-web/src/main/java/com/azure/spring/cloud/feature/manager/FeatureManagerSnapshot.java

...-feature-management/src/main/java/com/azure/spring/cloud/feature/manager/FeatureManager.java

...management/src/main/java/com/azure/spring/cloud/feature/manager/filters/TargetingFilter.java

...src/main/java/com/azure/spring/cloud/feature/manager/targeting/TargetingContextAccessor.java

sdk/spring/spring-cloud-azure-starter-appconfiguration-config/pom.xml

azure-sdk · 2023-03-15T20:48:58Z

API change check

APIView has identified API level changes in this PR and created following API reviews.

spring-cloud-azure-appconfiguration-config
spring-cloud-azure-appconfiguration-config-web
spring-cloud-azure-feature-management
spring-cloud-azure-feature-management-web

…flags even when disabled.

chenrujun

Please fix the pipeline failure.

...m/azure/spring/cloud/appconfiguration/config/implementation/AppConfigurationRefreshUtil.java

...-feature-management/src/main/java/com/azure/spring/cloud/feature/manager/FeatureManager.java

...src/main/java/com/azure/spring/cloud/feature/manager/targeting/TargetingContextAccessor.java

eng/code-quality-reports/src/main/resources/revapi/revapi.json

…refresh error. Updated TargetingContext method name.

mrm9084 · 2023-03-17T02:30:42Z

/azp run java - spring - tests

azure-pipelines · 2023-03-17T02:31:06Z

Azure Pipelines successfully started running 1 pipeline(s).

chenrujun

LGTM.

chenrujun · 2023-03-17T05:53:23Z

@mrm9084. The pipeline failure still exists. It only fails on ubuntu2004_117_netty.

chenrujun · 2023-03-20T01:18:52Z

/check-enforcer override

mrm9084 and others added 20 commits February 27, 2023 07:36

Adding FeatureFlag Tracing

b4476a7

Update test-resources.json

e10333d

Adding Container App info

c036b16

Fixing refresh bug with multiple feature flag filters in a single sto…

652e3d7

…re. Fixed bug were invalid feature flags would cause refresh loop.

Removed todo, has been fixed.

b5f2662

Merge branch 'main' into FeatureUsage

2689f9b

Update sdk/spring/spring-cloud-azure-appconfiguration-config/src/main…

ab76aa2

…/java/com/azure/spring/cloud/config/implementation/http/policy/TracingInfo.java Co-authored-by: Xiaolu Dai <31124698+saragluna@users.noreply.github.com>

Update sdk/spring/spring-cloud-azure-appconfiguration-config/src/main…

84f7476

…/java/com/azure/spring/cloud/config/implementation/http/policy/TracingInfo.java Co-authored-by: Xiaolu Dai <31124698+saragluna@users.noreply.github.com>

Update sdk/spring/spring-cloud-azure-appconfiguration-config/src/main…

342ff07

…/java/com/azure/spring/cloud/config/implementation/http/policy/TracingInfo.java Co-authored-by: Xiaolu Dai <31124698+saragluna@users.noreply.github.com>

Update sdk/spring/spring-cloud-azure-appconfiguration-config/src/main…

c83d94c

…/java/com/azure/spring/cloud/config/implementation/AppConfigurationReplicaClient.java Co-authored-by: Xiaolu Dai <31124698+saragluna@users.noreply.github.com>

Renaming Things from Arch Review

3181239

Code Review comments

afaf075

Update from comments

280ee53

Fixing watchKeySize

335692d

Updating Tracing usage

ada5596

Renaming Things from Arch Review

b41d2e6

Merge branch 'ArchReviewComments' of github.com:mrm9084/azure-sdk-for…

c0f83aa

…-java into ArchReviewComments

Fixing Merge Issues

4369b4a

Updating from Arch Review comments

fc47c41

Fixing Connection Strings support, multiple feature filters.

199a280

mrm9084 requested review from backwind1233, chenrujun, hui1110, Netyyyy, saragluna, stliu, yiliuTo, moarychan and fangjian0423 as code owners March 15, 2023 00:00

ghost added the azure-spring All azure-spring related issues label Mar 15, 2023

mrm9084 added 7 commits March 14, 2023 17:10

Updating Tracing usage

19d233a

Renaming Things from Arch Review

148729a

Renaming Things from Arch Review

5ccf615

Fixing Merge Issues

2e6dad5

Updating from Arch Review comments

c914ef1

Fixing Connection Strings support, multiple feature filters.

59b89e0

Merge branch 'ArchReviewComments' of github.com:mrm9084/azure-sdk-for…

04f3bbd

…-java into ArchReviewComments

chenrujun reviewed Mar 15, 2023

View reviewed changes

mrm9084 added 4 commits March 15, 2023 09:31

Fixing Merge Issue

132b769

Fixing Code review items

fbe333c

Fix Spelling

f77430f

Marking API Public

f19aadb

mrm9084 requested review from mssfang and JonathanGiles as code owners March 15, 2023 19:52

mrm9084 added 2 commits March 15, 2023 13:18

Fixing Health Indicator

781675b

Fixing docs and old name.

a363b5f

Fixed bug with multiple stores, second could try to refresh freature …

e7306cc

…flags even when disabled.

chenrujun reviewed Mar 16, 2023

View reviewed changes

mrm9084 added 3 commits March 15, 2023 22:48

Fixing same and unit test.

f830cd7

Fixing Allowed API

09178c9

Fixed Feature Management Refresh Bug where enabled but empty threw a …

b2d956d

…refresh error. Updated TargetingContext method name.

chenrujun approved these changes Mar 17, 2023

View reviewed changes

mrm9084 mentioned this pull request Mar 17, 2023

[AppConfig] Default to false if null returned when deserilizing ENABLED in feature flag setting #34091

Merged

6 tasks

chenrujun merged commit 9fb493a into Azure:main Mar 20, 2023

mrm9084 deleted the ArchReviewComments branch April 11, 2023 21:46

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

App Config Spring - Arch Review Comments #34022

App Config Spring - Arch Review Comments #34022

mrm9084 commented Mar 15, 2023

chenrujun left a comment

azure-sdk commented Mar 15, 2023 •

edited

Loading

chenrujun left a comment

mrm9084 commented Mar 17, 2023

azure-pipelines bot commented Mar 17, 2023

chenrujun left a comment

chenrujun commented Mar 17, 2023 •

edited

Loading

chenrujun commented Mar 20, 2023

App Config Spring - Arch Review Comments #34022

App Config Spring - Arch Review Comments #34022

Conversation

mrm9084 commented Mar 15, 2023

Description

All SDK Contribution checklist:

General Guidelines and Best Practices

Testing Guidelines

chenrujun left a comment

Choose a reason for hiding this comment

azure-sdk commented Mar 15, 2023 • edited Loading

chenrujun left a comment

Choose a reason for hiding this comment

mrm9084 commented Mar 17, 2023

azure-pipelines bot commented Mar 17, 2023

chenrujun left a comment

Choose a reason for hiding this comment

chenrujun commented Mar 17, 2023 • edited Loading

chenrujun commented Mar 20, 2023

azure-sdk commented Mar 15, 2023 •

edited

Loading

chenrujun commented Mar 17, 2023 •

edited

Loading