Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert test coverage settings for communication-identity #33441

Merged
merged 1 commit into from
Feb 10, 2023
Merged

Revert test coverage settings for communication-identity #33441

merged 1 commit into from
Feb 10, 2023

Conversation

petrsvihlik
Copy link
Contributor

@petrsvihlik petrsvihlik commented Feb 10, 2023 •
edited
Loading

Description

Reverting a change from #33397.
image

There haven't been any other changes in the codebase (neither implementation nor tests) that could cause the drop since Wednesday (the last time everything was passing), so let's revert this value.

All SDK Contribution checklist:

  • The pull request does not introduce [breaking changes]
  • CHANGELOG is updated for new features, bug fixes or other significant changes.
  • I have read the contribution guidelines.

General Guidelines and Best Practices

  • Title of the pull request is clear and informative.
  • There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For more information on cleaning up the commits in your PR, see this page.

Testing Guidelines

  • Pull request includes test coverage for the included changes.

@ghost ghost added the Communication label Feb 10, 2023
@petrsvihlik
Copy link
Contributor Author

/azp run java - azure-communication-identity - tests

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@petrsvihlik petrsvihlik marked this pull request as ready for review February 10, 2023 07:04
@petrsvihlik petrsvihlik enabled auto-merge (squash) February 10, 2023 07:04
@petrsvihlik petrsvihlik self-assigned this Feb 10, 2023
@petrsvihlik petrsvihlik merged commit f1d0cbd into Azure:main Feb 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rajuanitha88 rajuanitha88 rajuanitha88 approved these changes

@AikoBB AikoBB Awaiting requested review from AikoBB AikoBB is a code owner

@maximrytych-ms maximrytych-ms Awaiting requested review from maximrytych-ms maximrytych-ms is a code owner

@ostoliarova-msft ostoliarova-msft Awaiting requested review from ostoliarova-msft

@mjafferi-msft mjafferi-msft Awaiting requested review from mjafferi-msft mjafferi-msft is a code owner

Assignees

@petrsvihlik petrsvihlik

Labels
Communication - Identity Communication
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@petrsvihlik @rajuanitha88