Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change the log level of adding credits from Info to Debug #31910

Merged
merged 3 commits into from
Nov 10, 2022
Merged

Change the log level of adding credits from Info to Debug #31910

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
255ec12
Change add credit logs from INFO to Verbose
liukun-msft Nov 3, 2022
e04386d
Update CHANGELOG
liukun-msft Nov 3, 2022
587b3cc
Update CHANGELOG
liukun-msft Nov 8, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 5 additions & 4 deletions sdk/eventhubs/azure-messaging-eventhubs/CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,8 +7,9 @@
### Breaking Changes

### Bugs Fixed
- Fixed incorrect proxy configuration using environment variables. ([24230](https://github.com/Azure/azure-sdk-for-java/issues/24230))
- Fixed incorrect proxy configuration using environment variables. ([#24230](https://github.com/Azure/azure-sdk-for-java/issues/24230))
### Other Changes
- Changed the log level for adding credits from Info to Debug. ([#20836](https://github.com/Azure/azure-sdk-for-java/issues/20836))

## 5.14.0 (2022-10-13)

Expand All @@ -22,8 +23,8 @@
### Bugs Fixed

- Introducing ReactorShim to proxy certain reactive operations to appropriate Reactor operators, these are the operations for which recent Reactor versions have more optimized operators compared to an older version, or same operators with breaking change across Reactor versions
- When available, using the backpressure aware windowTimeout operator through ReactorShim. ([23950](https://github.com/Azure/azure-sdk-for-java/issues/23950))
- Fixed issue where FAIL_OVERFLOW when pushing events in EventHubBufferedProducerClient would result in a tight loop, so no more events would be published. ([30258](https://github.com/Azure/azure-sdk-for-java/issues/30258))
- When available, using the backpressure aware windowTimeout operator through ReactorShim. ([#23950](https://github.com/Azure/azure-sdk-for-java/issues/23950))
- Fixed issue where FAIL_OVERFLOW when pushing events in EventHubBufferedProducerClient would result in a tight loop, so no more events would be published. ([#30258](https://github.com/Azure/azure-sdk-for-java/issues/30258))

### Other Changes

Expand Down Expand Up @@ -64,7 +65,7 @@
### Bugs Fixed

- Introducing ReactorShim to proxy certain reactive operations to appropriate Reactor operators, these are the operations for which recent Reactor versions have more optimized operators compared to an older version, or same operators with breaking change across Reactor versions
- When available, using the backpressure aware windowTimeout operator through ReactorShim. ([23950](https://github.com/Azure/azure-sdk-for-java/issues/23950))
- When available, using the backpressure aware windowTimeout operator through ReactorShim. ([#23950](https://github.com/Azure/azure-sdk-for-java/issues/23950))

## 5.12.2 (2022-07-07)

Expand Down
2 changes: 1 addition & 1 deletion .../src/main/java/com/azure/messaging/eventhubs/implementation/AmqpReceiveLinkProcessor.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -673,7 +673,7 @@ private void addCreditsToLink(String message) {
// many events to buffer on the client and also control the throughput. If users need higher throughput,
// they can set a higher prefetch number and allocate larger heap size accordingly.
if (currentLinkCredits < prefetch) {
logger.atInfo()
logger.atVerbose()
.addKeyValue(LINK_NAME_KEY, linkName)
.addKeyValue(ENTITY_PATH_KEY, entityPath)
.addKeyValue(CREDITS_KEY, credits)
Expand Down
3 changes: 2 additions & 1 deletion sdk/servicebus/azure-messaging-servicebus/CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,9 +9,10 @@
### Breaking Changes

### Bugs Fixed
- Fixed incorrect proxy configuration using environment variables. ([24230](https://github.com/Azure/azure-sdk-for-java/issues/24230))
- Fixed incorrect proxy configuration using environment variables. ([#24230](https://github.com/Azure/azure-sdk-for-java/issues/24230))

### Other Changes
- Changed the log level for adding credits from Info to Debug. ([#20836](https://github.com/Azure/azure-sdk-for-java/issues/20836))

## 7.12.1 (2022-10-25)

Expand Down
2 changes: 1 addition & 1 deletion ...in/java/com/azure/messaging/servicebus/implementation/ServiceBusReceiveLinkProcessor.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -619,7 +619,7 @@ private int getCreditsToAdd(int linkCredits) {
: 0;
}

LOGGER.atInfo()
LOGGER.atVerbose()
.addKeyValue("prefetch", getPrefetch())
.addKeyValue(NUMBER_OF_REQUESTED_MESSAGES_KEY, r)
.addKeyValue("linkCredits", linkCredits)
Expand Down