Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Address api review comments for Default*Factory #27820

Merged
merged 2 commits into from
Mar 23, 2022
Merged

Address api review comments for Default*Factory #27820

merged 2 commits into from
Mar 23, 2022

Conversation

saragluna
Copy link
Member

This PR will address the api review comments:

  • Change setDefaultAzureCredential() to setDefaultCredential
  • Remove the static inner class from DefaultServiceBusNamespaceProcessorFactory.

@ghost ghost added the azure-spring All azure-spring related issues label Mar 23, 2022
@azure-sdk
Copy link
Collaborator

API changes have been detected in com.azure.spring:spring-messaging-azure. You can review API changes here

@azure-sdk
Copy link
Collaborator

API changes have been detected in com.azure.spring:spring-messaging-azure-eventhubs. You can review API changes here

@azure-sdk
Copy link
Collaborator

API changes have been detected in com.azure.spring:spring-messaging-azure-servicebus. You can review API changes here

@azure-sdk
Copy link
Collaborator

API changes have been detected in com.azure.spring:spring-cloud-azure-autoconfigure. You can review API changes here

@azure-sdk
Copy link
Collaborator

API changes have been detected in com.azure.spring:spring-cloud-azure-stream-binder-servicebus. You can review API changes here

@azure-sdk
Copy link
Collaborator

API changes have been detected in com.azure.spring:spring-cloud-azure-stream-binder-eventhubs. You can review API changes here

@azure-sdk
Copy link
Collaborator

API changes have been detected in com.azure.spring:spring-messaging-azure-eventhubs. You can review API changes here

yiliuTo
yiliuTo approved these changes Mar 23, 2022
View reviewed changes
Copy link
Member

@yiliuTo yiliuTo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@saragluna saragluna added this to the Spring Cloud Azure 4.0 GA milestone Mar 23, 2022
@saragluna saragluna merged commit 4438710 into Azure:feature/azure-spring-cloud-4.0 Mar 23, 2022
@saragluna saragluna deleted the xiada/address-apiview-comments5 branch April 12, 2022 05:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yiliuTo yiliuTo yiliuTo approved these changes

@backwind1233 backwind1233 Awaiting requested review from backwind1233

@chenrujun chenrujun Awaiting requested review from chenrujun

@hui1110 hui1110 Awaiting requested review from hui1110

@jialigit jialigit Awaiting requested review from jialigit

@stliu stliu Awaiting requested review from stliu

Assignees
No one assigned
Labels
azure-spring All azure-spring related issues
Projects
Spring Cloud Azure
Status: Done
Milestone
Spring Cloud Azure 4.0 GA
Development

Successfully merging this pull request may close these issues.
3 participants
@saragluna @azure-sdk @yiliuTo