Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove unused codes from Spring Cloud Azure #27722

Merged
merged 1 commit into from
Mar 18, 2022
Merged

Remove unused codes from Spring Cloud Azure #27722

merged 1 commit into from
Mar 18, 2022

Conversation

saragluna
Copy link
Member

This PR will remove unused codes from the KeyVaultOperation and KeyVaultPropertySource.

@ghost ghost added the azure-spring All azure-spring related issues label Mar 17, 2022
@azure-sdk
Copy link
Collaborator

API changes have been detected in com.azure.spring:spring-cloud-azure-autoconfigure. You can review API changes here

@saragluna saragluna closed this Mar 17, 2022
@saragluna saragluna deleted the xiada/remove-unused-codes branch March 17, 2022 05:26
@saragluna saragluna reopened this Mar 17, 2022
@saragluna saragluna restored the xiada/remove-unused-codes branch March 17, 2022 05:27
chenrujun
chenrujun reviewed Mar 17, 2022
View reviewed changes
...c/main/java/com/azure/spring/cloud/autoconfigure/keyvault/environment/KeyVaultOperation.java
@@ -205,21 +203,4 @@ void setProperties(HashMap<String, String> properties) {
this.properties = properties;
}

boolean isUp() {
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In main branch, it's used for KeyVaultHealthIndicator. Why KeyVaultHealthIndicator is deleted in 4.0 branch?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we use another method for kv health indicator now, and we do not have the kv health indicator for property source now.

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see.
Now for key vault secrets, we only have KeyVaultSecretHealthIndicator which only check health of SecretAsyncClient.

We can add health indicator for property source if customer ask for this feature in the future.

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you please add this into changelog?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

will do

chenrujun
chenrujun approved these changes Mar 18, 2022
View reviewed changes
Copy link

@chenrujun chenrujun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@saragluna saragluna added this to the Spring Cloud Azure 4.0 GA milestone Mar 18, 2022
@saragluna saragluna merged commit 9fe9738 into Azure:feature/azure-spring-cloud-4.0 Mar 18, 2022
@saragluna saragluna deleted the xiada/remove-unused-codes branch April 12, 2022 05:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chenrujun chenrujun chenrujun approved these changes

@backwind1233 backwind1233 Awaiting requested review from backwind1233

@hui1110 hui1110 Awaiting requested review from hui1110

@jialigit jialigit Awaiting requested review from jialigit

@stliu stliu Awaiting requested review from stliu

@yiliuTo yiliuTo Awaiting requested review from yiliuTo

Assignees
No one assigned
Labels
azure-spring All azure-spring related issues
Projects
Spring Cloud Azure
Status: Done
Milestone
Spring Cloud Azure 4.0 GA
Development

Successfully merging this pull request may close these issues.
3 participants
@saragluna @azure-sdk @chenrujun