Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Spring Cloud Azure rename all *CP classes to *ConfigurationProperties classes #26209

Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -4,13 +4,13 @@
package com.azure.spring.cloud.autoconfigure.appconfiguration.properties;

import com.azure.data.appconfiguration.ConfigurationServiceVersion;
import com.azure.spring.cloud.autoconfigure.properties.core.AbstractAzureHttpCP;
import com.azure.spring.cloud.autoconfigure.properties.core.AbstractAzureHttpConfigurationProperties;
import com.azure.spring.service.appconfiguration.ConfigurationClientProperties;

/**
* Properties for Azure App Configuration.
*/
public class AzureAppConfigurationProperties extends AbstractAzureHttpCP
public class AzureAppConfigurationProperties extends AbstractAzureHttpConfigurationProperties
implements ConfigurationClientProperties {

public static final String PREFIX = "spring.cloud.azure.appconfiguration";
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@
import com.azure.identity.DefaultAzureCredentialBuilder;
import com.azure.spring.cloud.autoconfigure.AzureServiceConfigurationBase;
import com.azure.spring.cloud.autoconfigure.properties.AzureGlobalProperties;
import com.azure.spring.cloud.autoconfigure.properties.core.AbstractAzureHttpCP;
import com.azure.spring.cloud.autoconfigure.properties.core.AbstractAzureHttpConfigurationProperties;
import com.azure.spring.core.customizer.AzureServiceClientBuilderCustomizer;
import com.azure.spring.core.factory.AbstractAzureServiceClientBuilderFactory;
import com.azure.spring.core.factory.credential.AbstractAzureCredentialBuilderFactory;
Expand Down Expand Up @@ -88,7 +88,7 @@ public void setBeanFactory(BeanFactory beanFactory) throws BeansException {
}
}

static class IdentityClientProperties extends AbstractAzureHttpCP {
static class IdentityClientProperties extends AbstractAzureHttpConfigurationProperties {

}
}
Original file line number Diff line number Diff line change
Expand Up @@ -9,9 +9,9 @@
import com.azure.cosmos.GatewayConnectionConfig;
import com.azure.cosmos.ThrottlingRetryOptions;
import com.azure.cosmos.models.CosmosPermissionProperties;
import com.azure.spring.cloud.autoconfigure.properties.core.AbstractAzureServiceCP;
import com.azure.spring.cloud.autoconfigure.properties.core.client.ClientCP;
import com.azure.spring.cloud.autoconfigure.properties.core.proxy.HttpProxyCP;
import com.azure.spring.cloud.autoconfigure.properties.core.AbstractAzureServiceConfigurationProperties;
import com.azure.spring.cloud.autoconfigure.properties.core.client.ClientConfigurationProperties;
import com.azure.spring.cloud.autoconfigure.properties.core.proxy.HttpProxyConfigurationProperties;
import com.azure.spring.service.cosmos.CosmosClientProperties;
import org.springframework.boot.context.properties.NestedConfigurationProperty;

Expand All @@ -21,15 +21,15 @@
/**
* Configuration properties for Cosmos database, consistency, telemetry, connection, query metrics and diagnostics.
*/
public class AzureCosmosProperties extends AbstractAzureServiceCP implements CosmosClientProperties {
public class AzureCosmosProperties extends AbstractAzureServiceConfigurationProperties implements CosmosClientProperties {

public static final String PREFIX = "spring.cloud.azure.cosmos";

@NestedConfigurationProperty
private final HttpProxyCP proxy = new HttpProxyCP();
private final HttpProxyConfigurationProperties proxy = new HttpProxyConfigurationProperties();

@NestedConfigurationProperty
private final ClientCP client = new ClientCP();
private final ClientConfigurationProperties client = new ClientConfigurationProperties();

private String endpoint;

Expand Down Expand Up @@ -72,12 +72,12 @@ public class AzureCosmosProperties extends AbstractAzureServiceCP implements Cos
private boolean populateQueryMetrics;

@Override
public HttpProxyCP getProxy() {
public HttpProxyConfigurationProperties getProxy() {
return proxy;
}

@Override
public ClientCP getClient() {
public ClientConfigurationProperties getClient() {
return client;
}

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -3,13 +3,13 @@

package com.azure.spring.cloud.autoconfigure.eventhubs.properties;

import com.azure.spring.cloud.autoconfigure.properties.core.AbstractAzureAmqpCP;
import com.azure.spring.cloud.autoconfigure.properties.core.AbstractAzureAmqpConfigurationProperties;
import com.azure.spring.core.implementation.connectionstring.EventHubsConnectionString;

/**
* Azure Event Hubs related properties.
*/
public abstract class AzureEventHubsCommonProperties extends AbstractAzureAmqpCP {
public abstract class AzureEventHubsCommonProperties extends AbstractAzureAmqpConfigurationProperties {

protected String domainName = "servicebus.windows.net";
protected String namespace;
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -3,14 +3,14 @@

package com.azure.spring.cloud.autoconfigure.keyvault.common;

import com.azure.spring.cloud.autoconfigure.properties.core.AbstractAzureHttpCP;
import com.azure.spring.cloud.autoconfigure.properties.core.AbstractAzureHttpConfigurationProperties;

/**
* Azure Key Vault properties.
*
* @since 4.0.0
*/
public class AzureKeyVaultProperties extends AbstractAzureHttpCP {
public class AzureKeyVaultProperties extends AbstractAzureHttpConfigurationProperties {

/**
* Azure Key Vault endpoint.
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@
package com.azure.spring.cloud.autoconfigure.keyvault.secrets;

import com.azure.security.keyvault.secrets.SecretServiceVersion;
import com.azure.spring.cloud.autoconfigure.properties.core.AbstractAzureHttpCP;
import com.azure.spring.cloud.autoconfigure.properties.core.AbstractAzureHttpConfigurationProperties;

import java.time.Duration;
import java.util.List;
Expand All @@ -16,7 +16,7 @@
*
* @since 4.0.0
*/
public class AzureKeyVaultPropertySourceProperties extends AbstractAzureHttpCP {
public class AzureKeyVaultPropertySourceProperties extends AbstractAzureHttpConfigurationProperties {

public static final Duration DEFAULT_REFRESH_INTERVAL = Duration.ofMinutes(30);

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -4,12 +4,12 @@
package com.azure.spring.cloud.autoconfigure.properties;

import com.azure.core.amqp.AmqpTransportType;
import com.azure.spring.cloud.autoconfigure.properties.core.authentication.TokenCredentialCP;
import com.azure.spring.cloud.autoconfigure.properties.core.client.ClientCP;
import com.azure.spring.cloud.autoconfigure.properties.core.client.HttpLoggingCP;
import com.azure.spring.cloud.autoconfigure.properties.core.profile.AzureProfileCP;
import com.azure.spring.cloud.autoconfigure.properties.core.proxy.ProxyCP;
import com.azure.spring.cloud.autoconfigure.properties.core.retry.RetryCP;
import com.azure.spring.cloud.autoconfigure.properties.core.authentication.TokenCredentialConfigurationProperties;
import com.azure.spring.cloud.autoconfigure.properties.core.client.ClientConfigurationProperties;
import com.azure.spring.cloud.autoconfigure.properties.core.client.HttpLoggingConfigurationProperties;
import com.azure.spring.cloud.autoconfigure.properties.core.profile.AzureProfileConfigurationProperties;
import com.azure.spring.cloud.autoconfigure.properties.core.proxy.ProxyConfigurationProperties;
import com.azure.spring.cloud.autoconfigure.properties.core.retry.RetryConfigurationProperties;
import com.azure.spring.core.properties.AzureProperties;
import org.springframework.boot.context.properties.ConfigurationProperties;
import org.springframework.boot.context.properties.NestedConfigurationProperty;
Expand All @@ -26,90 +26,90 @@ public class AzureGlobalProperties implements AzureProperties {
public static final String PREFIX = "spring.cloud.azure";

@NestedConfigurationProperty
private final GlobalClientCP client = new GlobalClientCP();
private final GlobalClientConfigurationProperties client = new GlobalClientConfigurationProperties();

@NestedConfigurationProperty
private final GlobalProxyCP proxy = new GlobalProxyCP();
private final GlobalProxyConfigurationProperties proxy = new GlobalProxyConfigurationProperties();

@NestedConfigurationProperty
private final GlobalRetryCP retry = new GlobalRetryCP();
private final GlobalRetryConfigurationProperties retry = new GlobalRetryConfigurationProperties();

@NestedConfigurationProperty
private final TokenCredentialCP credential = new TokenCredentialCP();
private final TokenCredentialConfigurationProperties credential = new TokenCredentialConfigurationProperties();

@NestedConfigurationProperty
private final AzureProfileCP profile = new AzureProfileCP();
private final AzureProfileConfigurationProperties profile = new AzureProfileConfigurationProperties();

@Override
public GlobalClientCP getClient() {
public GlobalClientConfigurationProperties getClient() {
return client;
}

@Override
public GlobalProxyCP getProxy() {
public GlobalProxyConfigurationProperties getProxy() {
return proxy;
}

@Override
public GlobalRetryCP getRetry() {
public GlobalRetryConfigurationProperties getRetry() {
return retry;
}

@Override
public TokenCredentialCP getCredential() {
public TokenCredentialConfigurationProperties getCredential() {
return credential;
}

@Override
public AzureProfileCP getProfile() {
public AzureProfileConfigurationProperties getProfile() {
return profile;
}

/**
* Global configurations for the transport client underneath.
*/
public static final class GlobalClientCP extends ClientCP {
public static final class GlobalClientConfigurationProperties extends ClientConfigurationProperties {

private final HttpClientCP http = new HttpClientCP();
private final AmqpClientCP amqp = new AmqpClientCP();
private final GlobalHttpClientConfigurationProperties http = new GlobalHttpClientConfigurationProperties();
private final GlobalAmqpClientConfigurationProperties amqp = new GlobalAmqpClientConfigurationProperties();

public HttpClientCP getHttp() {
public GlobalHttpClientConfigurationProperties getHttp() {
return http;
}

public AmqpClientCP getAmqp() {
public GlobalAmqpClientConfigurationProperties getAmqp() {
return amqp;
}
}

/**
* Global configurations for proxy.
*/
public static final class GlobalProxyCP extends ProxyCP {
public static final class GlobalProxyConfigurationProperties extends ProxyConfigurationProperties {

private final HttpProxyCP http = new HttpProxyCP();
private final GlobalHttpProxyConfigurationProperties http = new GlobalHttpProxyConfigurationProperties();

public HttpProxyCP getHttp() {
public GlobalHttpProxyConfigurationProperties getHttp() {
return http;
}
}

/**
* Global configurations for proxy.
*/
public static final class GlobalRetryCP extends RetryCP {
public static final class GlobalRetryConfigurationProperties extends RetryConfigurationProperties {

private final HttpRetryCP http = new HttpRetryCP();
private final GlobalHttpRetryConfigurationProperties http = new GlobalHttpRetryConfigurationProperties();

public HttpRetryCP getHttp() {
public GlobalHttpRetryConfigurationProperties getHttp() {
return http;
}
}

/**
* Retry properties only apply to http-based clients.
*/
public static final class HttpRetryCP {
public static final class GlobalHttpRetryConfigurationProperties {

/**
* HTTP header, such as Retry-After or x-ms-retry-after-ms, to lookup for the retry delay.
Expand Down Expand Up @@ -141,7 +141,7 @@ public void setRetryAfterTimeUnit(ChronoUnit retryAfterTimeUnit) {
/**
* Proxy properties only apply to http-based clients.
*/
public static final class HttpProxyCP {
public static final class GlobalHttpProxyConfigurationProperties {

/**
* A list of hosts or CIDR to not use proxy HTTP/HTTPS connections through.
Expand All @@ -160,7 +160,7 @@ public void setNonProxyHosts(String nonProxyHosts) {
/**
* Transport properties for http-based clients.
*/
public static final class HttpClientCP {
public static final class GlobalHttpClientConfigurationProperties {
/**
* Amount of time each request being sent over the wire.
*/
Expand All @@ -187,7 +187,7 @@ public static final class HttpClientCP {
private Duration connectionIdleTimeout;

@NestedConfigurationProperty
private final HttpLoggingCP logging = new HttpLoggingCP();
private final HttpLoggingConfigurationProperties logging = new HttpLoggingConfigurationProperties();

public Duration getWriteTimeout() {
return writeTimeout;
Expand Down Expand Up @@ -237,15 +237,15 @@ public void setConnectionIdleTimeout(Duration connectionIdleTimeout) {
this.connectionIdleTimeout = connectionIdleTimeout;
}

public HttpLoggingCP getLogging() {
public HttpLoggingConfigurationProperties getLogging() {
return logging;
}
}

/**
* Transport properties for amqp-based clients.
*/
public static final class AmqpClientCP {
public static final class GlobalAmqpClientConfigurationProperties {

/**
* Transport type for AMQP-based client.
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -3,37 +3,37 @@

package com.azure.spring.cloud.autoconfigure.properties.core;

import com.azure.spring.cloud.autoconfigure.properties.core.client.AmqpClientCP;
import com.azure.spring.cloud.autoconfigure.properties.core.proxy.ProxyCP;
import com.azure.spring.cloud.autoconfigure.properties.core.retry.RetryCP;
import com.azure.spring.cloud.autoconfigure.properties.core.client.AmqpClientConfigurationProperties;
import com.azure.spring.cloud.autoconfigure.properties.core.proxy.ProxyConfigurationProperties;
import com.azure.spring.cloud.autoconfigure.properties.core.retry.RetryConfigurationProperties;
import org.springframework.boot.context.properties.NestedConfigurationProperty;

/**
* Configuration properties base class for all AMQP-based Azure Service clients.
*/
public abstract class AbstractAzureAmqpCP extends AbstractAzureServiceCP {
public abstract class AbstractAzureAmqpConfigurationProperties extends AbstractAzureServiceConfigurationProperties {

@NestedConfigurationProperty
protected final AmqpClientCP client = new AmqpClientCP();
protected final AmqpClientConfigurationProperties client = new AmqpClientConfigurationProperties();

@NestedConfigurationProperty
protected final RetryCP retry = new RetryCP();
protected final RetryConfigurationProperties retry = new RetryConfigurationProperties();

@NestedConfigurationProperty
protected final ProxyCP proxy = new ProxyCP();
protected final ProxyConfigurationProperties proxy = new ProxyConfigurationProperties();

@Override
public AmqpClientCP getClient() {
public AmqpClientConfigurationProperties getClient() {
return client;
}

@Override
public RetryCP getRetry() {
public RetryConfigurationProperties getRetry() {
return retry;
}

@Override
public ProxyCP getProxy() {
public ProxyConfigurationProperties getProxy() {
return proxy;
}
}
Loading