Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove spring binder test module #26170

Conversation

moarychan
Copy link
Member

@moarychan moarychan commented Dec 24, 2021

This PR is used to enable the new feature of the pipeline for supporting multiple spring boot and spring cloud version compatibilities.

Due to the jackson version conflicts, we finally decide to use the single module to run our integration test cases. WIll move to the corresponding artifact id module in future.

@ghost ghost added azure-spring All azure-spring related issues customer-reported Issues that are reported by GitHub users external to the Azure organization. labels Dec 24, 2021
@ghost
Copy link

ghost commented Dec 24, 2021

Thank you for your contribution moarychan! We will review the pull request and get back to you soon.

@Netyyyy
Copy link
Member

Netyyyy commented Dec 24, 2021

/azp run java - spring - tests

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@check-enforcer
Copy link

This pull request is protected by Check Enforcer.

What is Check Enforcer?

Check Enforcer helps ensure all pull requests are covered by at least one check-run (typically an Azure Pipeline). When all check-runs associated with this pull request pass then Check Enforcer itself will pass.

Why am I getting this message?

You are getting this message because Check Enforcer did not detect any check-runs being associated with this pull request within five minutes. This may indicate that your pull request is not covered by any pipelines and so Check Enforcer is correctly blocking the pull request being merged.

What should I do now?

If the check-enforcer check-run is not passing and all other check-runs associated with this PR are passing (excluding license-cla) then you could try telling Check Enforcer to evaluate your pull request again. You can do this by adding a comment to this pull request as follows:
/check-enforcer evaluate
Typically evaulation only takes a few seconds. If you know that your pull request is not covered by a pipeline and this is expected you can override Check Enforcer using the following command:
/check-enforcer override
Note that using the override command triggers alerts so that follow-up investigations can occur (PRs still need to be approved as normal).

What if I am onboarding a new service?

Often, new services do not have validation pipelines associated with them, in order to bootstrap pipelines for a new service, you can issue the following command as a pull request comment:
/azp run prepare-pipelines
This will run a pipeline that analyzes the source tree and creates the pipelines necessary to build and validate your pull request. Once the pipeline has been created you can trigger the pipeline using the following comment:
/azp run java - [service] - ci

@Netyyyy
Copy link
Member

Netyyyy commented Dec 27, 2021

/azp run spring tests

@azure-pipelines
Copy link

No pipelines are associated with this pull request.

@Netyyyy
Copy link
Member

Netyyyy commented Dec 27, 2021

/azp run java - spring - tests

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

Copy link
Member

@saragluna saragluna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@@ -1,7 +1,7 @@
// Copyright (c) Microsoft Corporation. All rights reserved.
// Licensed under the MIT License.

package com.azure.spring.cloud.stream.binder.eventhubs;
package com.azure.spring.sample.eventhubs.binder;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: I think we should not use the package sample here.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I will change it in the next PR.

@Netyyyy Netyyyy merged commit 0ad3c54 into Azure:feature/azure-spring-cloud-4.0 Dec 27, 2021
@moarychan moarychan deleted the moary/remove-binder-test-module branch January 26, 2022 09:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
azure-spring All azure-spring related issues customer-reported Issues that are reported by GitHub users external to the Azure organization.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Move IT modules for spring cloud for azure messaging into the source code module
3 participants