-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Taking the parameter literally #25878
Conversation
Prerequisites: Need to change language repo first Python: Azure/azure-sdk-for-python#22047 JS: Azure/azure-sdk-for-js#19009 .NET: Azure/azure-sdk-for-net#25781 Java:Azure/azure-sdk-for-java#25878
This pull request is protected by Check Enforcer. What is Check Enforcer?Check Enforcer helps ensure all pull requests are covered by at least one check-run (typically an Azure Pipeline). When all check-runs associated with this pull request pass then Check Enforcer itself will pass. Why am I getting this message?You are getting this message because Check Enforcer did not detect any check-runs being associated with this pull request within five minutes. This may indicate that your pull request is not covered by any pipelines and so Check Enforcer is correctly blocking the pull request being merged. What should I do now?If the check-enforcer check-run is not passing and all other check-runs associated with this PR are passing (excluding license-cla) then you could try telling Check Enforcer to evaluate your pull request again. You can do this by adding a comment to this pull request as follows: What if I am onboarding a new service?Often, new services do not have validation pipelines associated with them, in order to bootstrap pipelines for a new service, you can issue the following command as a pull request comment: |
} | ||
|
||
function Validate-java-DocMsPackages ($PackageInfo, $DocValidationImageId) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
$DocValidationImageId
appears unused in both function signatures.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It is a placeholder. Our java docker image is broken. I will fix the image first before we adding the real logic
Not related to your changes here but a more general comment: as someone reviewing who isn't aware of the context of what you're working on, it would be helpful to have a more descriptive PR title and/or description of the changes (initial issue, intent of the change, problems fixed, decisions made, etc.). |
@benbp Add description as you suggested. |
27c165e
to
0b460e6
Compare
…to update_docms_packages
Description
We now have doc validation step in unified pipeline and release pipeline.
The PR is to implement the validation function in each language.
We also have docindex pipeline for all package validation. Make some changes to make it work.
All SDK Contribution checklist:
General Guidelines and Best Practices
Testing Guidelines