Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix warnings reported by api-review for AAD and AAD-B2C #25849

Merged
merged 5 commits into from
Dec 8, 2021
Merged

Fix warnings reported by api-review for AAD and AAD-B2C #25849

merged 5 commits into from
Dec 8, 2021

Conversation

chenrujun
Copy link

@chenrujun chenrujun commented Dec 7, 2021 •
edited
Loading

  1. Reorganize the package of AAD and AAD B2C related classes.
    • AAD and AADB2C are different thing, not put AAD B2C related classes into AAD package.
    • Move configuration classes and property classes out of "implementation" package.
    • Move Classes used by customer out of "implementation" package.
    • If a class is used in a non-implementation class's public method's parameter type / return type. Move it out of "implementation" package.
  2. Add missed java docs.

Here is the link to api-review after this PR: https://apiview.dev/Assemblies/Review/627f1d980d854f0fb219ad4d9a48e54c

@ghost ghost added the azure-spring All azure-spring related issues label Dec 7, 2021
@azure-sdk
Copy link
Collaborator

API changes have been detected in com.azure:azure-core. You can review API changes here

@chenrujun chenrujun changed the title Api review for aad related module Fix warnings reported by api-review for AAD and AAD-B2C Dec 7, 2021
@chenrujun chenrujun self-assigned this Dec 7, 2021
@chenrujun chenrujun added this to the [2022] January milestone Dec 7, 2021
saragluna
saragluna approved these changes Dec 8, 2021
View reviewed changes
Copy link
Member

@saragluna saragluna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@chenrujun
Copy link
Author

Merging this PR.
Ignoring the pipeline because the failure is not caused by this PR.

@chenrujun chenrujun merged commit a4941b0 into Azure:feature/azure-spring-cloud-4.0 Dec 8, 2021
@chenrujun chenrujun deleted the api-review-for-aad-related-module branch December 8, 2021 05:57
@chenrujun chenrujun mentioned this pull request Dec 8, 2021
Merged
@chenrujun chenrujun linked an issue Dec 8, 2021 that may be closed by this pull request
API review for Security modules #24416
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stliu stliu stliu left review comments

@saragluna saragluna saragluna approved these changes

@backwind1233 backwind1233 Awaiting requested review from backwind1233

@hui1110 hui1110 Awaiting requested review from hui1110

@jialigit jialigit Awaiting requested review from jialigit

@JonathanGiles JonathanGiles Awaiting requested review from JonathanGiles

@mssfang mssfang Awaiting requested review from mssfang

@yiliuTo yiliuTo Awaiting requested review from yiliuTo

Assignees

@chenrujun chenrujun

Labels
azure-spring All azure-spring related issues
Projects
Spring Cloud Azure
Status: Done
Milestone
Spring Cloud Azure 4.0 Beta3
Development

Successfully merging this pull request may close these issues.

API review for Security modules
5 participants
@chenrujun @azure-sdk @stliu @saragluna @rujche