Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix API review warnings in for autoconfigure.keyvault and autoconfigure.messaging #25798

Conversation

chenrujun
Copy link

@chenrujun chenrujun commented Dec 3, 2021

As title.

Fix warnings in api-review page: https://apiview.dev/Assemblies/Review/783a66f61ccd4452a67fbebfafb6fcd3#com.azure.spring.cloud.autoconfigure.keyvault.certificates

This PR is only for these packages:

  1. com.azure.spring.cloud.autoconfigure.keyvault.
  2. com.azure.spring.cloud.autoconfigure.messaging

@ghost ghost added the azure-spring All azure-spring related issues label Dec 3, 2021
@chenrujun chenrujun self-assigned this Dec 3, 2021
@chenrujun
Copy link
Author

Hi, @saragluna , please help to review this PR when you have time.

@chenrujun chenrujun changed the title Fix the warnings in this package: com.azure.spring.cloud.autoconfigur… Fix API review warnings in for autoconfigure.keyvault and autoconfigure.messaging Dec 3, 2021
@chenrujun
Copy link
Author

@saragluna ping.

@chenrujun
Copy link
Author

@saragluna , updated.

Copy link
Member

@saragluna saragluna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@chenrujun chenrujun merged commit f6f4d82 into Azure:feature/azure-spring-cloud-4.0 Dec 6, 2021
@chenrujun chenrujun deleted the api-review-for-keyvault-package branch December 6, 2021 09:11
@chenrujun chenrujun linked an issue Dec 8, 2021 that may be closed by this pull request
@saragluna saragluna added this to the Spring Cloud Azure 4.0 Beta3 milestone Jan 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
azure-spring All azure-spring related issues
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

API review for Security modules
3 participants