Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor spring messaging eventhubs #25057

Conversation

saragluna
Copy link
Member

The current structure of spring messaging eventhubs includes three layers, spring-messaging-azure-eventhubs, spring-integration-azure-eventhubs, spring-cloud-azure-stream--binder-eventhubs. However, current implementation has some problems, such as can't configuration an eventhub's configuration from integration and stream-binder, messaging-azure-eventhubs aware of integration's logic. This PR is trying to refactor these three modules and fix these problems.

@ghost ghost added the azure-spring All azure-spring related issues label Oct 27, 2021
@saragluna saragluna changed the title Refactor messaging eventhubs Refactor spring messaging eventhubs Oct 27, 2021
@azure-sdk
Copy link
Collaborator

API changes have been detected in com.azure:azure-core. You can review API changes here

API changes

-     @Retention(RetentionPolicy.RUNTIME)
-     @Target(ElementType.METHOD)
-     @Retention
-     @Target
-     public @interface Options {
-         String value();
-     }

@saragluna saragluna force-pushed the xiada/feature/spring-cloud-azure-integration-and-binder-configuration branch from 5391b5f to 1a4f3d7 Compare October 27, 2021 09:18
@saragluna saragluna force-pushed the xiada/feature/spring-cloud-azure-integration-and-binder-configuration branch from 1a4f3d7 to 6afd9ba Compare October 28, 2021 08:25
@saragluna
Copy link
Member Author

/azp run java - spring - tests

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@saragluna
Copy link
Member Author

/azp run java - spring - tests

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@saragluna
Copy link
Member Author

/azp run java - spring - tests

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@saragluna
Copy link
Member Author

/azp run java - spring - tests

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

Copy link
Member

@yiliuTo yiliuTo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
azure-spring All azure-spring related issues
Projects
None yet
3 participants