Servicebus health indicator implementation and doc. #23050
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
ZhuXiaoBing-cn
commented
Jul 19, 2021
•
- Add health indicator doc.
- Service bus health indicator logic implementation.
- Add unit tests.
* Modify the Health Indicator logic. * Add Unit Tests.
* Add package-info.java file. * Fix unit test errors.
saragluna
requested changes
Jul 23, 2021
sdk/spring/azure-spring-cloud-autoconfigure/HEALTH_INDICATOR_README.md
Outdated
Show resolved
Hide resolved
...ion-servicebus/src/main/java/com/azure/spring/integration/servicebus/ServiceBusTemplate.java
Outdated
Show resolved
Hide resolved
# Conflicts: # sdk/spring/azure-spring-cloud-stream-binder-servicebus-queue/pom.xml # sdk/spring/azure-spring-cloud-stream-binder-servicebus-topic/pom.xml # sdk/spring/azure-spring-integration-servicebus/src/main/java/com/azure/spring/integration/servicebus/ServiceBusTemplate.java # sdk/spring/azure-spring-integration-servicebus/src/main/java/com/azure/spring/integration/servicebus/queue/ServiceBusQueueTemplate.java # sdk/spring/azure-spring-integration-servicebus/src/main/java/com/azure/spring/integration/servicebus/topic/ServiceBusTopicTemplate.java
* Add unit tests.
# Conflicts: # sdk/spring/azure-spring-cloud-autoconfigure/src/main/java/com/azure/spring/cloud/autoconfigure/servicebus/AzureServiceBusQueueAutoConfiguration.java # sdk/spring/azure-spring-cloud-autoconfigure/src/main/java/com/azure/spring/cloud/autoconfigure/servicebus/AzureServiceBusTopicAutoConfiguration.java
saragluna
requested changes
Aug 4, 2021
...n/java/com/azure/spring/cloud/autoconfigure/servicebus/AzureServiceBusAutoConfiguration.java
Outdated
Show resolved
Hide resolved
...a/com/azure/spring/cloud/autoconfigure/servicebus/AzureServiceBusQueueAutoConfiguration.java
Outdated
Show resolved
Hide resolved
...a/com/azure/spring/cloud/autoconfigure/servicebus/AzureServiceBusTopicAutoConfiguration.java
Outdated
Show resolved
Hide resolved
...com/azure/spring/integration/servicebus/topic/ServiceBusTopicOperationSendSubscribeTest.java
Outdated
Show resolved
Hide resolved
.../src/test/java/com/azure/spring/integration/servicebus/topic/TopicTemplateSubscribeTest.java
Outdated
Show resolved
Hide resolved
saragluna
requested changes
Aug 6, 2021
.../src/main/java/com/azure/spring/servicebus/stream/binder/ServiceBusQueueHealthIndicator.java
Show resolved
Hide resolved
...est/java/com/azure/spring/servicebus/stream/binder/support/ServiceBusQueueTestOperation.java
Outdated
Show resolved
Hide resolved
...est/java/com/azure/spring/servicebus/stream/binder/support/ServiceBusTopicTestOperation.java
Outdated
Show resolved
Hide resolved
...servicebus/src/main/java/com/azure/spring/integration/servicebus/health/Instrumentation.java
Outdated
Show resolved
Hide resolved
.../test/java/com/azure/spring/integration/servicebus/support/ServiceBusQueueTestOperation.java
Outdated
Show resolved
Hide resolved
...com/azure/spring/integration/servicebus/queue/ServiceBusQueueOperationSendSubscribeTest.java
Outdated
Show resolved
Hide resolved
.../test/java/com/azure/spring/integration/servicebus/support/ServiceBusTopicTestOperation.java
Outdated
Show resolved
Hide resolved
* Modify code logic.
saragluna
requested changes
Aug 6, 2021
.../src/main/java/com/azure/spring/servicebus/stream/binder/ServiceBusQueueHealthIndicator.java
Show resolved
Hide resolved
saragluna
requested changes
Aug 6, 2021
...com/azure/spring/integration/servicebus/topic/ServiceBusTopicOperationSendSubscribeTest.java
Outdated
Show resolved
Hide resolved
...cebus/src/test/java/com/azure/spring/integration/servicebus/topic/TopicTemplateSendTest.java
Outdated
Show resolved
Hide resolved
* Remove blank lines.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.