Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

App Configuration - Bug Fixes #18977

Merged

Conversation

mrm9084
Copy link
Member

@mrm9084 mrm9084 commented Feb 4, 2021

  • Re-added configuration to turn of refresh.
  • Fixed issue where the wrong refresh label was used when not defined.
  • Web Configuration should only load if AppConfigurationRefresh is made
  • Fixes priority order of multiple spring profiles
    • spring.profiles.active= v1,v2
    • In this case if both v1 and v2 have a configuration value v2 should have priority.

…h. Fixed issue where the wrong refresh label was used when not defined.
@ghost ghost added the App Configuration Azure.ApplicationModel.Configuration label Feb 4, 2021
@check-enforcer
Copy link

check-enforcer bot commented Feb 4, 2021

This pull request is protected by Check Enforcer.

What is Check Enforcer?

Check Enforcer helps ensure all pull requests are covered by at least one check-run (typically an Azure Pipeline). When all check-runs associated with this pull request pass then Check Enforcer itself will pass.

Why am I getting this message?

You are getting this message because Check Enforcer did not detect any check-runs being associated with this pull request within five minutes. This may indicate that your pull request is not covered by any pipelines and so Check Enforcer is correctly blocking the pull request being merged.

What should I do now?

If the check-enforcer check-run is not passing and all other check-runs associated with this PR are passing (excluding license-cla) then you could try telling Check Enforcer to evaluate your pull request again. You can do this by adding a comment to this pull request as follows:
/check-enforcer evaluate
Typically evaulation only takes a few seconds. If you know that your pull request is not covered by a pipeline and this is expected you can override Check Enforcer using the following command:
/check-enforcer override
Note that using the override command triggers alerts so that follow-up investigations can occur (PRs still need to be approved as normal).

What if I am onboarding a new service?

Often, new services do not have validation pipelines associated with them, in order to bootstrap pipelines for a new service, you can issue the following command as a pull request comment:
/azp run prepare-pipelines
This will run a pipeline that analyzes the source tree and creates the pipelines necessary to build and validate your pull request. Once the pipeline has been created you can trigger the pipeline using the following comment:
/azp run java - [service] - ci

@mrm9084 mrm9084 merged commit 3482442 into Azure:app-config-v2-branch Feb 9, 2021
@mrm9084 mrm9084 deleted the AppConfigNewConfigurations branch February 9, 2021 21:23
@saragluna saragluna added the azure-spring-app-configuration Spring app configuration related issues. label Feb 10, 2021
azure-sdk pushed a commit to azure-sdk/azure-sdk-for-java that referenced this pull request May 12, 2022
[Microsoft.KubernetesConfiguration] Add 200 OK to PATCH apis (Azure#18977)

* Add response codes to patch apis

* Examples for patch of extension and configuration
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
App Configuration Azure.ApplicationModel.Configuration azure-spring-app-configuration Spring app configuration related issues.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants