Remove DigitalTwins Writable property, rewrite Basic classes to match .NET #16896
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| ); | ||
|
|
||
| String basicDigitalTwinPayload = mapper.writeValueAsString(basicTwin); |
There was a problem hiding this comment.
This field wasn't used anywhere, so I deleted it
azabbasi
approved these changes
Oct 27, 2020
| */ | ||
| public class BasicDigitalTwinPropertyMetadata { | ||
| @JsonProperty(value = DigitalTwinsJsonPropertyNames.METADATA_PROPERTY_LAST_UPDATE_TIME, required = true) | ||
| private OffsetDateTime lastUpdatedOn; |
There was a problem hiding this comment.
I know we decided to use lastUpdatedOn, I just wanted to say I think lastUpdatedTime might have been a better property name. goodbye
There was a problem hiding this comment.
Sadly this is the name the service choose, so I'm not looking to change it.
Scratch that, the service went with "lastUpdateTime" but Azure SDK team prefers we name like the above. We already renamed the digital twins model data class' date time field like this, so it should pass review
drwill-ms
approved these changes
Oct 27, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Writable property isn't sent by the service anymore, so we don't need it in our serialization types.
Also adding/changing a couple of Basic types to match what we have in .NET such as BasicDigitalTwinComponentMetadata