Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Nightly Test Command #16892

Merged
merged 3 commits into from
Oct 27, 2020

Conversation

alzimmermsft
Copy link
Member

This PR fixes a discrepancy between the testing command used during PR validation and the daily test run. The daily test run used the test lifecycle phase instead of verify which PR validation was using. This resulted in a scenario where Jacoco modified the built library byte code to capture test coverage but never cleaned up the changes as that happens during the subsequent lifecycle phase. Not cleaning up the byte code modifications resulted in CI failures when the libraries in the build set had dependencies upon each other.

@alzimmermsft alzimmermsft added EngSys This issue is impacting the engineering system. common common module used by all azure SDKs (e.g. client, Mgmt) test bug Problem in test source code (most likely) labels Oct 27, 2020
@alzimmermsft alzimmermsft self-assigned this Oct 27, 2020
Copy link
Member

@srnagar srnagar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@alzimmermsft
Copy link
Member Author

alzimmermsft commented Oct 27, 2020

/azp run java - core - tests

@azure-pipelines
Copy link

No pipelines are associated with this pull request.

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@alzimmermsft
Copy link
Member Author

/azp run java - core - tests

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@alzimmermsft alzimmermsft merged commit 017a6c7 into Azure:master Oct 27, 2020
@alzimmermsft alzimmermsft deleted the AzEng_AlignPRAndNightlyCI branch October 27, 2020 21:54
openapi-sdkautomation bot pushed a commit to AzureSDKAutomation/azure-sdk-for-java that referenced this pull request Nov 29, 2021
loadtestservice-typescript.md-update (Azure#16892)
openapi-sdkautomation bot pushed a commit to AzureSDKAutomation/azure-sdk-for-java that referenced this pull request Jan 5, 2022
loadtestservice-typescript.md-update (Azure#16892)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
common common module used by all azure SDKs (e.g. client, Mgmt) EngSys This issue is impacting the engineering system. test bug Problem in test source code (most likely)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants