Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Storage identity remove resource manager provider #15837

Closed
Changes from 1 commit
Commits
Show all changes
56 commits
Select commit Hold shift + click to select a range
03f8ab4
In progress
mnriem Aug 5, 2020
7266ac5
Throw an exception when configuration is incomplete
mnriem Aug 6, 2020
0de9b40
Added class level JavaDoc
mnriem Aug 6, 2020
3964b68
Resolve POM conflict
mnriem Aug 6, 2020
9fb49ba
Added unit tests
mnriem Aug 6, 2020
9acd2b9
Merge branch 'credential-helper' of https://github.com/mnriem/azure-s…
yevster Aug 12, 2020
bedcf50
Changing the Identity Helper into a builder
yevster Aug 13, 2020
9ad8a79
Adding storage resource sample, autoconfiguration for blob storage wi…
yevster Aug 15, 2020
f9adbe0
Attempting to generate an endpoint string
yevster Aug 17, 2020
9cac0d3
Provisional workaround for using IdentityToken in Shared service conn…
yevster Aug 21, 2020
c2bbb46
Merge branch 'master' into storage-identity
yevster Aug 22, 2020
41f32fa
In progress
mnriem Aug 5, 2020
8c1297b
Throw an exception when configuration is incomplete
mnriem Aug 6, 2020
f0322af
Added class level JavaDoc
mnriem Aug 6, 2020
8a6385c
Resolve POM conflict
mnriem Aug 6, 2020
9305ee1
Added unit tests
mnriem Aug 6, 2020
92fd3dd
Changing the Identity Helper into a builder
yevster Aug 13, 2020
06d8aa9
Adding storage resource sample, autoconfiguration for blob storage wi…
yevster Aug 15, 2020
723e463
Attempting to generate an endpoint string
yevster Aug 17, 2020
62c5533
Provisional workaround for using IdentityToken in Shared service conn…
yevster Aug 21, 2020
b96c739
Merge branch 'storage-identity' of github.com:yevster/azure-sdk-for-j…
yevster Sep 14, 2020
3f7e8ac
XML syntax fix
yevster Sep 14, 2020
670e4a2
Storage resource demo works
yevster Sep 17, 2020
cfef365
Removing tight Resource Manager Provider coupling
yevster Sep 30, 2020
f7f9414
Merge branch 'master' into storage-identity-remove-resource-manager-p…
yevster Oct 2, 2020
9662b85
Fixing autoconfiguration for legacy resource management to not kick i…
yevster Oct 3, 2020
6f780a9
Merge branch 'master' into storage-identity-remove-resource-manager-p…
yevster Oct 8, 2020
ef3f807
Resource demo works with file legacy file credentail'
yevster Oct 15, 2020
525c5b4
Resource sample works with environment parameters
yevster Oct 15, 2020
7d7adb1
Removing debugging code
yevster Oct 15, 2020
80a9e20
Fixing SPEL expression to omit legacy auto-config when using Spring e…
yevster Oct 15, 2020
9277d71
checkstyle appeasement
yevster Oct 17, 2020
e4608d5
Checktyle appeasement, version fixing
yevster Oct 19, 2020
42d5e50
Adding mock token credentail to Actuator test config to ward off unea…
yevster Oct 20, 2020
29beabc
Adding mock token credentail to Actuator test config to ward off unea…
yevster Oct 21, 2020
969353e
Removing topic manager dependency from queue autoconfig
yevster Oct 22, 2020
bbc811e
Fixing autoconfig dependencies for Topic binders
yevster Oct 22, 2020
01b1378
Fixing startup failure when namespace is provided instead of connection
yevster Oct 28, 2020
cc74b40
Updating to incorporate upstream library signature changes
yevster Oct 28, 2020
cdb5ed4
Merge branch 'master' into storage-identity-remove-resource-manager-p…
saragluna Oct 28, 2020
bccd6e2
include version tag should be on the same line
saragluna Oct 28, 2020
9a206f1
Spring Cloud Stream - Event Hub binder demo now works
yevster Oct 28, 2020
f19af87
merging with master
yevster Oct 29, 2020
7bec935
Fixing build failures
yevster Oct 29, 2020
456d383
Preventing reliance on resource management bean when resource group
yevster Oct 30, 2020
9b1792b
Merge branch 'master' into storage-identity-remove-resource-manager-p…
yevster Oct 30, 2020
fcb8bc8
Fixing NPE in auto-configuration
yevster Oct 30, 2020
a6cfcfe
Fixing NPE in auto-configuration
yevster Oct 30, 2020
8277c89
Fixing package names broken in merge
yevster Oct 30, 2020
005e67f
Checkstyle appeasement
yevster Oct 30, 2020
552af0c
Checkstyle appeasement
yevster Oct 30, 2020
2456b26
Merge branch 'context-config-npe-fix' into storage-identity-remove-re…
yevster Oct 30, 2020
8558375
Eliminating ServiceBus ARM dependency when not pulled in thorugh sett…
yevster Oct 31, 2020
dde0594
Deleting duplicate sample
yevster Oct 31, 2020
2a7d5a3
Removing module for superfluous storage resource demeo
yevster Nov 2, 2020
5531c84
Fixing parent pom of identity library
yevster Nov 2, 2020
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Resource demo works with file legacy file credentail'
yevster committed Oct 15, 2020
commit ef3f807699f8e7ba1a80be2ca155d0bb750a8263
Original file line number Diff line number Diff line change
@@ -8,6 +8,8 @@
import org.springframework.core.env.Environment;

import com.azure.core.credential.TokenCredential;
import com.azure.identity.ChainedTokenCredential;
import com.azure.identity.ChainedTokenCredentialBuilder;
import com.azure.identity.ClientCertificateCredentialBuilder;
import com.azure.identity.ClientSecretCredentialBuilder;
import com.azure.identity.DefaultAzureCredentialBuilder;
@@ -54,121 +56,143 @@
*/
public class SpringEnvironmentTokenBuilder {

/**
* Defines the AZURE_CREDENTIAL_PREFIX.
*/
private static final String AZURE_CREDENTIAL_PREFIX = "azure.credential.";

/**
* Stores the named credentials.
*/
private final HashMap<String, TokenCredential> credentials;

/**
* Stores the name of the credential to be returned. If omitted, the default
* credential will be returned.
*/
private String name = "";

/**
* Constructor.
*/
public SpringEnvironmentTokenBuilder() {
credentials = new HashMap<>();
credentials.put("", new DefaultAzureCredentialBuilder().build());
}

/**
* Populate from Environment.
*
* @param environment the environment.
*/
public SpringEnvironmentTokenBuilder fromEnvironment(Environment environment) {
populateNamedCredential(environment, "");
String credentialNamesKey = AZURE_CREDENTIAL_PREFIX + "names";
if (environment.containsProperty(credentialNamesKey)) {
String[] credentialNames = environment.getProperty(credentialNamesKey).split(",");
for (int i = 0; i < credentialNames.length; i++) {
populateNamedCredential(environment, credentialNames[i]);
}
}
return this;
}

/**
* Populate a named credential.
*
* @param environment the environment
* @param name the name.
*/
private void populateNamedCredential(Environment environment, String name) {
String standardizedName = name;

if (!standardizedName.equals("") && !standardizedName.endsWith(".")) {
standardizedName = standardizedName + ".";
}

String tenantIdKey = AZURE_CREDENTIAL_PREFIX + standardizedName + "tenantId";
String clientIdKey = AZURE_CREDENTIAL_PREFIX + standardizedName + "clientId";
String clientSecretKey = AZURE_CREDENTIAL_PREFIX + standardizedName + "clientSecret";

String tenantId = environment.getProperty(tenantIdKey);
String clientId = environment.getProperty(clientIdKey);
String clientSecret = environment.getProperty(clientSecretKey);

if (tenantId != null && clientId != null && clientSecret != null) {
TokenCredential credential = new ClientSecretCredentialBuilder().tenantId(tenantId).clientId(clientId)
.clientSecret(clientSecret).build();
credentials.put(name, credential);
return;
}

String clientCertificateKey = AZURE_CREDENTIAL_PREFIX + standardizedName + "clientCertificate";
String clientCertificatePath = environment.getProperty(clientCertificateKey);

if (tenantId != null && clientId != null && clientCertificatePath != null) {
TokenCredential credential = new ClientCertificateCredentialBuilder().tenantId(tenantId).clientId(clientId)
.pemCertificate(clientCertificatePath).build();
credentials.put(name, credential);
return;
}

if (!name.equals("")) {
throw new IllegalStateException("Configuration for azure.credential." + name + " is incomplete");
}
}

/**
* Sets the builder to return a credential named <code>name</code>
*
* @param name
* @return
*/
public SpringEnvironmentTokenBuilder namedCredential(String name) {
this.name = name;
return this;
}

/**
* Sets the builder to return the default credential.
*/
public SpringEnvironmentTokenBuilder defaultCredential() {
return namedCredential("");
}

/**
* Builds an Azure TokenCredendial.
*
* @throws IllegalArgumentException if attempting to retrieve a named credential
* not defined in the environment.
*/
public TokenCredential build() {
TokenCredential result = credentials.get(name);
if (result == null) {
throw new IllegalArgumentException(
"Attempting to retrieve Azure credential not configured in the environment. (name=" + name + ")");
} else {
return result;
}
}
/**
* Defines the AZURE_CREDENTIAL_PREFIX.
*/
private static final String AZURE_CREDENTIAL_PREFIX = "azure.credential.";

/**
* Stores the named credentials.
*/
private final HashMap<String, TokenCredential> credentials;

/**
* Stores the name of the credential to be returned. If omitted, the default
* credential will be returned.
*/
private String name = "";

/**
* Constructor.
*/
public SpringEnvironmentTokenBuilder() {
credentials = new HashMap<>();
credentials.put("", new DefaultAzureCredentialBuilder().build());
}

/**
* Populate from Environment.
*
* @param environment the environment.
*/
public SpringEnvironmentTokenBuilder fromEnvironment(Environment environment) {
populateNamedCredential(environment, "");
String credentialNamesKey = AZURE_CREDENTIAL_PREFIX + "names";
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it possible to consider make use of @ConfigurationProperties and model different credentials as Map, so that we don't need the 'names' here.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a repackaging of @mnriem's code, so perhaps he can answer better. My understanding is that a custom map is needed because property values could come from multiple sources, and this serves to consolidate them in a single place.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The 'names' defines the order of the chain.

if (environment.containsProperty(credentialNamesKey)) {
String[] credentialNames = environment.getProperty(credentialNamesKey).split(",");
for (int i = 0; i < credentialNames.length; i++) {
populateNamedCredential(environment, credentialNames[i]);
}
}
return this;
}

/**
* Sets a credential to override a named credential. If this credential fails to produce a token,
* the original token credential will be used.
*
* @param name
* @param credential
* @return
*/
public SpringEnvironmentTokenBuilder overrideNamedCredential(String name, TokenCredential credential) {
TokenCredential currentCredential = credentials.get(name);
if (currentCredential == null) {
credentials.put(name, credential);
} else {
ChainedTokenCredentialBuilder builder = new ChainedTokenCredentialBuilder();
builder.addFirst(credential);
builder.addLast(currentCredential);
credentials.put(name, builder.build());
}

return this;
}

/**
* Populate a named credential.
*
* @param environment the environment
* @param name the name.
*/
private void populateNamedCredential(Environment environment, String name) {
String standardizedName = name;

if (!standardizedName.equals("") && !standardizedName.endsWith(".")) {
standardizedName = standardizedName + ".";
}

String tenantIdKey = AZURE_CREDENTIAL_PREFIX + standardizedName + "tenantId";
String clientIdKey = AZURE_CREDENTIAL_PREFIX + standardizedName + "clientId";
String clientSecretKey = AZURE_CREDENTIAL_PREFIX + standardizedName + "clientSecret";

String tenantId = environment.getProperty(tenantIdKey);
String clientId = environment.getProperty(clientIdKey);
String clientSecret = environment.getProperty(clientSecretKey);

if (tenantId != null && clientId != null && clientSecret != null) {
TokenCredential credential = new ClientSecretCredentialBuilder().tenantId(tenantId).clientId(clientId)
.clientSecret(clientSecret).build();
credentials.put(name, credential);
return;
}

String clientCertificateKey = AZURE_CREDENTIAL_PREFIX + standardizedName + "clientCertificate";
String clientCertificatePath = environment.getProperty(clientCertificateKey);

if (tenantId != null && clientId != null && clientCertificatePath != null) {
TokenCredential credential = new ClientCertificateCredentialBuilder().tenantId(tenantId).clientId(clientId)
.pemCertificate(clientCertificatePath).build();
credentials.put(name, credential);
return;
}

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For system assigned identity, tenant id is needed.
For user assigned identity, tenant id and one optional client id is needed.

Code here has some problems work with system assigned identity and user assigned identity.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would it be simpler to always fall back to DefaultAzureCredentialBuilder?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I defer to @mnriem on this.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For system assigned you do not need tenant id. User-assigned was not targeted and would need to be added if required.

if (!name.equals("")) {
throw new IllegalStateException("Configuration for azure.credential." + name + " is incomplete");
}
}

/**
* Sets the builder to return a credential named <code>name</code>
*
* @param name
* @return
*/
public SpringEnvironmentTokenBuilder namedCredential(String name) {
this.name = name;
return this;
}

/**
* Sets the builder to return the default credential.
*/
public SpringEnvironmentTokenBuilder defaultCredential() {
return namedCredential("");
}

/**
* Builds an Azure TokenCredendial.
*
* @throws IllegalArgumentException if attempting to retrieve a named credential
* not defined in the environment.
*/
public TokenCredential build() {
TokenCredential result = credentials.get(name);
if (result == null) {
throw new IllegalArgumentException(
"Attempting to retrieve Azure credential not configured in the environment. (name=" + name + ")");
} else {
return result;
}
}
}
Loading